Skip to content

fix: pass expose-gc via NODE_OPTIONS in test scripts#5054

Closed
mcollina wants to merge 1 commit intomainfrom
fix/ci-borp-expose-gc
Closed

fix: pass expose-gc via NODE_OPTIONS in test scripts#5054
mcollina wants to merge 1 commit intomainfrom
fix/ci-borp-expose-gc

Conversation

@mcollina
Copy link
Copy Markdown
Member

Summary

  • pass --expose-gc to GC-dependent test runs via NODE_OPTIONS
  • stop relying on borp --expose-gc forwarding the flag into the executed test process
  • restore CI coverage for the test:unit, test:fetch, test:eventsource, and test:tdd scripts

Testing

  • npm run test:unit
  • npm run test:fetch
  • npm run test:eventsource

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.07%. Comparing base (a516f87) to head (0c05e01).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5054      +/-   ##
==========================================
- Coverage   93.08%   93.07%   -0.02%     
==========================================
  Files         110      110              
  Lines       35804    35804              
==========================================
- Hits        33327    33323       -4     
- Misses       2477     2481       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants