Add setgroups(2) to macOS/Apple targets#2793
Conversation
|
The test failures seem to be related to Linux kernel exploit mitigations (the FreeBSD one I don't know though). |
They are unrelated, don't worry about them. Update: you can rebase your branch after #2796 is merged. |
SteveLauC
left a comment
There was a problem hiding this comment.
Maybe we should also add the other two functions as well:
- initgroups
- getgroups
I previously had concerns about the weird semantics of getgtoups, but that does not really bother me anymore since Nix is ultimately just a bindings crate.
| /// | ||
| /// [Further reading](https://man7.org/linux/man-pages/man2/getgroups.2.html) | ||
| /// | ||
| /// **Note:** This function is not available for Apple platforms. On those |
There was a problem hiding this comment.
This comment should be updated if we expose it on apple targets.
|
A changelog entry is needed, see https://github.com/nix-rust/nix/blob/master/CONTRIBUTING.md#pull-requests. |
What does this PR do
This is related to #2069 and kpcyrd/acme-redirect#50, the
setgroupsapi definitely exists, but it's currently not available in nix for that target, causing compile errors with some projects.The nix commit had some information that was likely not accurate:
Quoting from @Elizafox in #2069 (which I believe to be correct):
Checklist:
CONTRIBUTING.md