Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s Rust dependencies (and Rust edition) and adjusts source to compile against newer crate APIs (notably ureq, rand, and nix), plus adds unit tests for certificate parsing.
Changes:
- Bump Rust edition to 2024 and update multiple dependencies (Cargo.toml/Cargo.lock).
- Update code to match new APIs (capability dropping cfg, ureq request config + body reading, rand token generation).
- Add unit tests for
CertInfoparsing anddays_leftcalculations.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/sandbox.rs |
Makes Linux capabilities clearing conditional; changes supplementary group clearing behind a macOS cfg. |
src/persist.rs |
Refactors live cert symlink parsing using let-chains; minor import reordering. |
src/errors.rs |
Reorders anyhow re-exports. |
src/daemon.rs |
Simplifies Host header extraction; import reordering. |
src/check.rs |
Updates HTTP check logic for ureq v3 config/builder API and body reading. |
src/chall.rs |
Updates random token generation for rand v0.10 APIs and adds clarifying comments. |
src/cert.rs |
Adds PartialEq, introduces days_left_from, and adds certificate parsing/unit tests. |
Cargo.toml |
Moves to Rust 2024 edition and bumps dependency versions. |
Cargo.lock |
Regenerates lockfile for updated dependencies. |
.github/FUNDING.yml |
Removes Patreon funding entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| repository = "https://github.com/kpcyrd/acme-redirect" | ||
| readme = "README.md" | ||
| edition = "2021" | ||
| edition = "2024" |
|
|
||
| if let Some((uid, gid)) = user { | ||
| debug!("Dropping uid:gid to {}:{}", uid, gid); | ||
| #[cfg(not(target_os = "macos"))] |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.