Repository navigation
feat(specs): make built-in inventory visibility configurable #2379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mvschwarz
merged 7 commits into
mvschwarz:main
from
Nikhila-Dhevi-R:codex/spec-library-visibility-2333
Nov 3, 2026
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c6c7563
feat(specs): make built-in inventory visibility configurable
Nikhila-Dhevi-R 4088711
test(cli): accept built-in lookup on rig launch
Nikhila-Dhevi-R d07906a
test(cli): cover bootstrap built-in lookup
Nikhila-Dhevi-R a9543c9
fix(specs): preserve workflow copy links after edits
Nikhila-Dhevi-R 8368144
Merge remote-tracking branch 'origin/main' into codex/spec-library-vi…
Nikhila-Dhevi-R 96a6adb
fix(specs): bind workflow source links to current content
Nikhila-Dhevi-R 77d9ae9
docs(specs): show how to find hidden built-in IDs
Nikhila-Dhevi-R File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import type { DaemonClient } from "../src/client.js"; | ||
| import { resolveDefaultAgentRef } from "../src/commands/topology-default-agent.js"; | ||
|
|
||
| describe("default agent lookup", () => { | ||
| it("finds the built-in orchestrator when inventory hides built-ins", async () => { | ||
| const client = { | ||
| get: async (url: string) => ({ | ||
| data: url.includes("include_builtins=true") | ||
| ? [{ kind: "agent", name: "orchestrator", sourceType: "builtin", sourcePath: "/builtin/orchestrator/agent.yaml" }] | ||
| : [], | ||
| }), | ||
| } as unknown as DaemonClient; | ||
| expect(await resolveDefaultAgentRef(client, "codex")).toBe("path:/builtin/orchestrator"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: mvschwarz/openrig
Length of output: 7763
Script executed:
Repository: mvschwarz/openrig
Length of output: 42036
Script executed:
Repository: mvschwarz/openrig
Length of output: 18512
Prefer the user spec for same-name lookups.
With the default
specs.builtins_visible=true, the first library response can contain both the user spec and the built-in.resolveLibrarySpecthen reportsSpec name '<name>' is ambiguousinstead of selecting the user spec. This breaks same-nameshow,preview, bootstrap, and launch lookups.Suggested fix
Committable suggestion