[njbrake]

Description

Fourth of six stacked PRs. Targets #1552.

admin-api.ts hand-declared 80 interfaces under a comment claiming they "match backend schemas exactly". Twenty-one had an exact counterpart in src/generated/api.d.ts and are now aliases to it, matching what src/types.ts already does.

The generated types are stricter: tool_calls and args come out optional. That is a spec artifact, not an API behavior. A Pydantic default_factory emits no default key, and openapi-typescript marks a property required only when it is in required or carries a default. FastAPI serializes with exclude_unset=False, so those fields are always on the wire. The nullish guards added at the 14 call sites satisfy the type checker and change nothing at runtime.

Aliasing did surface a real inconsistency: LLMEndpointItem typed cache_control, reasoning, and pricing as plain strings while LLMEndpointUpsert typed the same three as Literals, so a value read from a GET could not be handed back to a PUT. The three sets now live in enums.py and are used by the ORM column, both schemas, and the service writer.

openapi.json and api.d.ts regenerated and committed.

Type

• Refactor

Checklist

• Tests pass (uv run pytest -v): 4268 passed, 6 skipped; frontend 425 passed, tsc and knip clean
• Lint passes (ruff check backend/ && ruff format --check backend/)
• New tests added for new functionality
• Bug fixes include regression tests

AI Usage

• AI-assisted: written by Claude Opus 5 via back-and-forth with @njbrake.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: mozilla-ai/clawbolt/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 7f45b67a-5afa-468b-b7d5-7e1537aa7598

📥 Commits

Reviewing files that changed from the base of the PR and between d08f76a and c71a8aa.

⛔ Files ignored due to path filters (1)

• frontend/src/generated/api.d.ts is excluded by !**/generated/**

📒 Files selected for processing (7)

• backend/app/enums.py
• backend/app/models/llm.py
• backend/app/schemas/llm.py
• backend/app/services/llm_endpoints.py
• frontend/openapi.json
• frontend/src/extensions/admin/admin-api.ts
• frontend/src/extensions/admin/tabs/shared.tsx

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}