[njbrake]

Description

Sixth of six stacked PRs. Targets #1554.

Every change here came out of reviewing the five PRs beneath it. Grouped by what found it:

#1550 review. The query-helper migration was applied to about half the eligible sites, leaving both idioms live inside the same function bodies; user_profile.get_heartbeat_logs had a hand-rolled count matching count_rows' own docstring example two lines above a fetch_all. Converted the remaining 13. AGENTS.md still told contributors to hand-roll those shapes, which is how the half-migration would have become permanent. Also dropped a byte-identical copy of iso_or_none, 14 redundant paren wrappers, a list() around an already-list, and the sync get_or_404, which had no callers.

#1551 review. AGENTS.md named four files the module split deleted. Every agent session reads that file first. heartbeat_frequency.py carried dead copies of two constants, one of whose comments says both sides import it so the strings cannot drift. Three delete-message schemas sat in schemas/heartbeat.py with nothing to do with heartbeats. Dropped a routerless APIRouter, a sync resolve_heartbeat_route with no callers, and two get_settings_store patches whose comment described an FK failure that does not happen: removing both leaves all 86 tests in that file green, before the split too.

#1552 review. Routing webchat's upload check through check_media_size changed the 422 detail from "File too large" to "Media file too large". The pytest assertion lowercases before comparing so it stayed green; e2e/oss/file-upload.spec.ts is case-sensitive and would have turned e2e-playwright red on merge. Keeping the unified wording and updating the assertion. assemble_turn_tools now primes the tool registry itself: sampling.py documents what happens when a caller forgets, which is that both models are offered no tools, agree perfectly, and the report reads as a clean pass.

#1553 review. The admin-api.ts header comment promised spec parity over 59 hand-written types, two of which had drifted: CompactUserContextResult was missing previous_event_id and EvalModelTotals was missing pricing_unknown_reason. Both are aliases now, and aliasing the second immediately failed the build because the eval fixtures were missing that field too. config.tsx's dropdown options are typed against the spec, so removing a value backend-side fails the build instead of offering an option every PUT would reject. endpoint_item no longer reports a mode column verbatim: those columns are plain String(16), so a hand-written UPDATE could 500 the whole endpoint list over one bad row, and it now falls back to auto with a warning the way the agent path already does.

Type

• Bug fix
• Refactor
• Documentation

Checklist

• Tests pass (uv run pytest -v): 4268 passed, 6 skipped; frontend 425 passed, tsc and knip clean
• Lint passes (ruff check backend/ && ruff format --check backend/)
• New tests added for new functionality
• Bug fixes include regression tests: the e2e assertion is the regression test for the message change; the endpoint_item fallback and the drift guard were each verified by mutation

AI Usage

• AI-assisted: written by Claude Opus 5 via back-and-forth with @njbrake. Each finding came from an independent review agent rather than from the author.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: mozilla-ai/clawbolt/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6a9ddbab-ffec-424c-8bb9-031e8e93aa71

📥 Commits

Reviewing files that changed from the base of the PR and between 41e9ec2 and 4c39b8b.

📒 Files selected for processing (35)

• AGENTS.md
• TODOS.md
• backend/app/agent/approval.py
• backend/app/agent/heartbeat_frequency.py
• backend/app/agent/heartbeat_routing.py
• backend/app/agent/inbound_recovery.py
• backend/app/agent/ingestion.py
• backend/app/agent/media_staging.py
• backend/app/agent/session_db.py
• backend/app/agent/stores.py
• backend/app/agent/tool_assembly.py
• backend/app/main.py
• backend/app/query_helpers.py
• backend/app/routers/admin/access.py
• backend/app/routers/admin/users.py
• backend/app/routers/admin_llm_eval.py
• backend/app/routers/admin_shared_data/approvals.py
• backend/app/routers/admin_shared_data/compaction.py
• backend/app/routers/admin_shared_data/consent.py
• backend/app/routers/admin_shared_data/conversations.py
• backend/app/routers/admin_shared_data/export.py
• backend/app/routers/admin_shared_data/profile.py
• backend/app/routers/admin_shared_data/summary.py
• backend/app/routers/user_profile.py
• backend/app/routers/user_sessions.py
• backend/app/schemas/heartbeat.py
• backend/app/schemas/user.py
• backend/app/services/llm_endpoints.py
• backend/app/services/user_deletion.py
• fiximports.py
• frontend/src/extensions/admin/admin-api.ts
• frontend/src/extensions/admin/tabs/config.tsx
• frontend/src/extensions/admin/tabs/model-eval-fixtures.ts
• frontend/src/extensions/admin/tabs/shared.tsx
• tests/multi_user/test_admin_router.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}