Repository navigation
fix(ci): preserve cleanup boundaries and bounded failure assertions - #1618
Conversation
Interrupt optional CDP domain shutdown on caller cancellation while preserving independent bounded detach. Align EVM, firmware and Qwen boundary regressions with retained cleanup owners and managed-file removal; retain original overflow facts without expanding megabyte-sized assertion diffs.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Independent review confirms the mid-cleanup cancellation fix and managed-file ownership assertions. I am adding a narrow EVM follow-up here: the outer cleanup error describes the same retained process failure, and its previous-error metadata also duplicates the complete captured stdout. Keep the original output-limit cause, one canonical captured-output copy and the original cleanup resources/owner. An actual owned subprocess overflow control reduces the projected error from 2,098,769 to 1,049,484 bytes while retaining all 1,048,576 captured stdout bytes, truncation, the original cause and retryable root cleanup. Real small-target CLI/pinned-SDK MCP controls also passed for a five-byte EVM bytecode and a 66-byte Chrome page, including cancellation, external-target preservation and subsequent ping. Those measurements are from the independently verified candidate on main |
Summary
Cancel optional CDP domain shutdown promptly while retaining an independent, bounded detach attempt. Repair inherited CI regressions around retained cleanup owners and REA-owned skill removal, without discarding original failure facts or user files.
Found while babysitting #1613: its first shard and another unrelated PR had the same six failures. No separate issue was opened for these directly reproduced blockers. The firmware worker assertion overlaps the correction in #1616; this PR does not implement its workspace recovery feature.
Problem and expected behavior
When cancellation arrives during a hung
Page.disable, the optional shutdown currently consumes the entire cleanup budget, preventingTarget.detachFromTarget. Cancellation should stop optional shutdown and preserve the remaining detach budget. Already cancelled operations should skip optional domain disabling and still detach; they must never close a user target or browser.The EVM regression expected an old flattened error and premature workspace deletion, the firmware regression allowed a second unverified worker, and the Qwen regression expected recursive skill-directory deletion. Current ownership rules require preserving the cleanup owner/root, refusing another unverified launch, and removing only managed skill files. The megabyte-sized EVM assertion diff also delayed CI log output by about 25 minutes after the tests had finished.
Change and scope
Contract and boundary impact
Evidence and regression coverage
For evidence-bearing changes:
Validation performed
npm run check— passed typecheck, lint, formatting, metadata, unused-code and architecture checks.e4ac2f8a.Compatibility, safety, and release
Review checklist