Repository navigation
perf(evm): avoid repeated cleanup diagnostics - #1622
Merged
Merged
Conversation
Incorporate the connection-release controls from #1617 while retaining the independent detach regression.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An EVM command output overflow combined with incomplete cleanup currently wraps the same cleanup failure twice and repeats the full captured stdout in previous-error metadata. Return the original mapped failure while retaining its cleanup owner and resources, and keep stdout/stderr once in canonical
captured_output. The original output-limit cause, exit/signal facts, truncation and retry behavior remain available. No new output caps or tool/schema changes.The regression uses actual owned subprocess output and retryable cleanup, with a bounded assertion projection so a failure cannot print megabytes of diagnostics. It also verifies that an uncertain owner blocks another launch until cleanup recovers. Browser socket-release and external-target controls proposed in closed #1617 are retained alongside the detach regression from merged #1618. This is the remaining follow-up after those existing PRs were handled.
Refs #1065. Follow-up to #1618 and #1617.
Validation on main
16d9c5adplus this change (0ab1e7f7):Linux x64, Node 24.18.0. No chain/bytecode execution, real firmware extraction or Hopper/Ghidra claim. Existing large-folder JavaScript OOM #1563 remains open.