Skip to content

guard against nil span when calculating offset #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pjdavis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

guard against nil span when calculating offset #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/chronic/repeaters/repeater_minute.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ def this(pointer = :future)
end

def offset(span, amount, pointer)
return nil unless span

direction = pointer == :future ? 1 : -1
span + direction * amount * MINUTE_SECONDS
end
Expand Down
3 changes: 3 additions & 0 deletions test/test_parsing.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,6 +1070,9 @@ def test_parse_guess_nonsense

time = parse_now("t")
assert_nil time

time = parse_now("01 Jan 1953 to 31 Dec 1954")
assert_nil time
end

def test_parse_span
Expand Down