guard against nil span when calculating offset#388
Open
pjdavis wants to merge 1 commit intomojombo:masterfrom
Open
guard against nil span when calculating offset#388pjdavis wants to merge 1 commit intomojombo:masterfrom
span when calculating offset#388pjdavis wants to merge 1 commit intomojombo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given a date range of the format "%d %b %Y to %d %b %Y" such as "01 Jan 1988 to 31 Dec 1999" chronic will throw the error
NoMethodError (undefined method '+' for nil:NilClass). This happens because getting the anchor won't work for some weirder date formats and just returns nil, that in turn gets passed to the offset method.It looks like it could probably happen with other repeaters as well, but I was unable to craft a string of sufficient silliness to cause it to happen in other repeaters.
Now, instead of throwing an error, Chronic.parse will just return nil, which is consistent with the documentation.