fix(ci): keep the transformers<5.0 pin through the package install - #9862
fix(ci): keep the transformers<5.0 pin through the package install#9862he-yufeng wants to merge 1 commit into
Conversation
The pin line runs before pip install ., but a pip invocation keeps no constraints across runs. The package install re-resolves trl (floor transformers>=4.56.2) against framework.txt's <5.15.0 and jumps to transformers 5.14.1, after which the suite dies importing transformers.models.gemma3 (currently red on every PR, e.g. modelscope#9854). Carrying the pin into the package install keeps the resolver on the 4.x line the tests are written for; verified it selects 4.57.6 with trl 0.29.1 in the same run. Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
|
I traced the full failing run and found a second resolver mutation that this patch does not cover. In run 31179195838, the initial pin correctly installs Transformers 4.57.6. Later, The same sequence appears in the five currently red PR runs (#9850, #9852, #9859, #9870, #9871). Therefore carrying |
The pin line in the CUDA path runs before
pip install ., but pip keeps no constraints across invocations. The package install then re-resolves trl (floortransformers>=4.56.2) against framework.txt's<5.15.0and jumps to transformers 5.14.1, after which the suite dies importingtransformers.models.gemma3. Every PR is red on this right now (confirmed on mine and on #9854, same error in the same step).Carrying the pin into the package install keeps the resolver on the 4.x line the suite is written for. Verified with the actual resolver:
trl==0.29.1+transformers<5.0in one run selects transformers 4.57.6, which satisfies trl's floor and keeps gemma3 importable.The NPU path already carries the pin inside its own command and is untouched. Whether framework.txt itself should drop
<5.15.0for users is a bigger support-range question I left alone here.