fix(utils): report free port search exhaustion - #9870
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Raise a clear error when every candidate port is occupied and keep high-range scans within the valid TCP port range. Test: python tests/run.py --test_dir tests/utils --pattern test_port_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
find_free_port()returned the last candidate even when every bind attemptfailed. Deploy and app argument initialization could therefore accept an
occupied port and only fail later when starting the server.
This change:
OSErrorafter exhausting the candidate range;The change is limited to port selection. It does not reserve the returned port
or alter the existing bind interface.
Experiment results
Before:
when all three mocked bind attempts raised
OSError.After:
Verification: