Repository navigation
exporter/containerimage: normalize platform in annotation keys - #7245
Closed
ricardobranco777 wants to merge 1 commit into
Closed
ricardobranco777 wants to merge 1 commit into
ricardobranco777 wants to merge 1 commit into
Conversation
Annotation keys such as annotation-manifest-descriptor[linux/arm64/v8].k were grouped by the platform exactly as written, but looked up using the normalized build platform (linux/arm64). The mismatch silently dropped the annotation. This is easy to hit on arm64, where platforms.DefaultSpec() includes the v8 variant. Normalize the platform when parsing the key, and when looking up annotations for a platform, so equivalent spellings match. Signed-off-by: Ricardo Branco <rbranco@suse.de>
Member
|
Already opened #7244 for the same fix. Looks like we picked this up at the same time 😅 |
Author
LOL. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotation keys such as annotation-manifest-descriptor[linux/arm64/v8].k were grouped by the platform exactly as written, but looked up using the normalized build platform (linux/arm64). The mismatch silently dropped the annotation. This is easy to hit on arm64, where platforms.DefaultSpec() includes the v8 variant.
Normalize the platform when parsing the key, and when looking up annotations for a platform, so equivalent spellings match.
See docker/buildx#4126 for more details.