Repository navigation
tests: normalize platform in TestBuildAnnotations descriptor key - #4126
Merged
tonistiigi merged 1 commit intoOct 5, 2026
Merged
Conversation
On arm64, platforms.DefaultSpec() returns linux/arm64/v8, while the worker reports linux/arm64. The manifest-descriptor annotation key therefore matched no platform and the annotation was silently dropped, causing the example4 assertion to fail. The image lookup in the same test already uses platforms.Normalize; do the same for the annotation key. Signed-off-by: Ricardo Branco <rbranco@suse.de>
ricardobranco777
marked this pull request as draft
October 5, 2026 14:04
ricardobranco777
marked this pull request as ready for review
October 5, 2026 14:22
Contributor
Author
|
Verification run: https://openqa.opensuse.org/tests/6253112#step/docker_buildx/119 |
crazy-max
approved these changes
Oct 5, 2026
crazy-max
left a comment
Member
There was a problem hiding this comment.
LGTM thanks
I looked a bit further into why this fails in your CI. On arm64, DefaultSpec() includes v8, but BuildKit normalizes the exported platform to linux/arm64. The annotation lookup uses an exact platform key, so linux/arm64/v8 doesn't match and the annotation gets dropped.
I think we should also normalize annotation platforms in BuildKit so users passing linux/arm64/v8 don't hit the same issue.
Contributor
Author
Created moby/buildkit#7245 for this |
tonistiigi
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On arm64, platforms.DefaultSpec() returns linux/arm64/v8, while the worker reports linux/arm64. The manifest-descriptor annotation key therefore matched no platform and the annotation was silently dropped, causing the example4 assertion to fail. The image lookup in the same test already uses platforms.Normalize; do the same for the annotation key.
Otherwise test fails in openQA like this:
http://openqa-assets.opensuse.org/tests/6252345/file/docker_buildx-buildx.txt