Add test project for Microsoft.TestPlatform.Filter.Source source-only package#15649
Merged
Youssef1313 merged 4 commits intodev/ygerges/filter-source-pkgfrom Apr 8, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/vstest/sessions/7eda9b9e-90f6-4186-950f-4990ee4d4330 Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/vstest/sessions/7eda9b9e-90f6-4186-950f-4990ee4d4330 Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Create source-only filter package
Add test project for Microsoft.TestPlatform.Filter.Source source-only package
Apr 8, 2026
Youssef1313
reviewed
Apr 8, 2026
Agent-Logs-Url: https://github.com/microsoft/vstest/sessions/f40a484c-cfb2-4282-8562-6ed492acf35b Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test project that validates the
Microsoft.TestPlatform.Filter.Sourcesource-only package by compiling its source files directly (as end-users would via NuGet), without referencing the csproj.Key design points
<Compile Include="..." />items, mirroring real consumer usageIsFilterSourcePackage=true— preventsIS_VSTEST_REPOfrom being defined, so theinternal sealed/[Embedded]code paths are exercisedBeforeTargets="ResolveProjectReferences"target removes theFromP2Pvstest project references added byDirectory.Build.targets, which would otherwise cause CS0436 type conflicts between the inlined source and the compiled vstest assembliesTests covered
FilterHelper—Escape,Unescape, invalid escape sequences, roundtripFilterExpressionWrapper— parse error detection,Evaluatewith=,!=,~,&,|,ValidForProperties, fast-filter constructionTestCaseFilterExpression—MatchTestCase,ValidForProperties, null guard on constructor, parse-error short-circuit