-
Notifications
You must be signed in to change notification settings - Fork 7.5k
[sparrow-ipc] Create recipe and add version 1.0.0 #51010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Alex-PLACET
wants to merge
9
commits into
microsoft:master
Choose a base branch
from
Alex-PLACET:sparrow-ipc-1.0.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+70
−0
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
91e375b
Add sparrow-ipc 1.0.0
Alex-PLACET a2b82f3
Add sparrow-ipc version 1.0.0 to baseline and create version file
Alex-PLACET b4c7688
Update homepage URL for sparrow-ipc to point to the correct repository
Alex-PLACET 9999f23
Add flatbuffers as a dependency for sparrow-ipc
Alex-PLACET c38e7a2
wip
Alex-PLACET 7153a80
Reorder dependencies in vcpkg.json to include arcticdb-sparrow with v…
Alex-PLACET bf0b922
Fix dependency order in vcpkg.json and update git-tree in sparrow-ipc…
Alex-PLACET 8fa5354
Add lz4 and zstd as dependencies for sparrow-ipc
Alex-PLACET 168e3f9
Update git-tree for sparrow-ipc to latest commit
Alex-PLACET File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,32 @@ | ||||||
| if(VCPKG_TARGET_IS_LINUX) | ||||||
| message("Warning: `sparrow-ipc` requires Clang18+ or GCC 11.2+ on Linux") | ||||||
| endif() | ||||||
|
|
||||||
| vcpkg_from_github( | ||||||
| OUT_SOURCE_PATH SOURCE_PATH | ||||||
| REPO sparrow-org/sparrow-ipc | ||||||
| REF "${VERSION}" | ||||||
| SHA512 73c7bb4505bffcf1bdfbb68cd77b0b395c59e463b863c5dd219985b68bc6644d70b54131321c0675b315cd9ef02fcc34534e9c3e5d09f0b8b1b3402c5b1073a4 | ||||||
| HEAD_REF main | ||||||
| ) | ||||||
|
|
||||||
| if (VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic") | ||||||
| set(SPARROW_IPC_BUILD_SHARED ON) | ||||||
| else() | ||||||
| set(SPARROW_IPC_BBUILD_SHARED OFF) | ||||||
| endif() | ||||||
|
|
||||||
| vcpkg_cmake_configure( | ||||||
| SOURCE_PATH "${SOURCE_PATH}" | ||||||
| OPTIONS | ||||||
| ${FEATURE_OPTIONS} | ||||||
| -DSPARROW_IPC_BUILD_SHARED=${SPARROW_BUILD_SHARED} | ||||||
| ) | ||||||
|
|
||||||
| vcpkg_cmake_install() | ||||||
| vcpkg_cmake_config_fixup(PACKAGE_NAME sparrow-ipc CONFIG_PATH share/cmake/sparrow-ipc) | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
PACKAGE_NAME parameter is not necessary in this case. |
||||||
|
|
||||||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include") | ||||||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/share") | ||||||
|
|
||||||
| vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE") | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,25 @@ | ||||||||
| { | ||||||||
| "name": "sparrow-ipc", | ||||||||
| "version": "1.0.0", | ||||||||
| "description": "C++20 idiomatic APIs for the Apache Arrow Serialization and Interprocess Communication (IPC)", | ||||||||
| "homepage": "https://github.com/sparrow-org/sparrow-ipc", | ||||||||
| "license": "BSD-3-Clause", | ||||||||
| "supports": "!uwp", | ||||||||
| "dependencies": [ | ||||||||
| { | ||||||||
| "name": "arcticdb-sparrow", | ||||||||
| "version>=": "2.4.0" | ||||||||
|
Comment on lines
+10
to
+11
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
We don't usually allow version constraints for packages in the registry. |
||||||||
| }, | ||||||||
| "flatbuffers", | ||||||||
| "lz4", | ||||||||
| { | ||||||||
| "name": "vcpkg-cmake", | ||||||||
| "host": true | ||||||||
| }, | ||||||||
| { | ||||||||
| "name": "vcpkg-cmake-config", | ||||||||
| "host": true | ||||||||
| }, | ||||||||
| "zstd" | ||||||||
| ] | ||||||||
| } | ||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "versions": [ | ||
| { | ||
| "git-tree": "bedc8b908de21df8200edcaec25c6ddd182b73ec", | ||
| "version": "1.0.0", | ||
| "port-version": 0 | ||
| } | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.