Skip to content

[sparrow-ipc] Create recipe and add version 1.0.0#51010

Draft
Alex-PLACET wants to merge 9 commits intomicrosoft:masterfrom
Alex-PLACET:sparrow-ipc-1.0.0
Draft

[sparrow-ipc] Create recipe and add version 1.0.0#51010
Alex-PLACET wants to merge 9 commits intomicrosoft:masterfrom
Alex-PLACET:sparrow-ipc-1.0.0

Conversation

@Alex-PLACET
Copy link
Copy Markdown
Contributor

@Alex-PLACET Alex-PLACET commented Apr 7, 2026

  • Changes comply with the maintainer guide.
  • The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
    • The project is in Repology: https://repology.org//versions
    • The project is amongst the first web search results for "" or " C++". Include a screenshot of the search engine results in the PR.
    • The port name follows the 'GitHubOrg-GitHubRepo' form or equivalent Owner-Project form.
  • Optional dependencies of the build are all controlled by the port. A dependency is controlled if it is declared an unconditional dependency in vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGE
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is brief and accurate. See adding-usage for context. Don't add a usage file if the automatically generated usage is correct.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

@Alex-PLACET Alex-PLACET marked this pull request as ready for review April 7, 2026 13:24
Copy link
Copy Markdown
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits.

Comment on lines +10 to +11
"name": "arcticdb-sparrow",
"version>=": "2.4.0"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "arcticdb-sparrow",
"version>=": "2.4.0"
"name": "arcticdb-sparrow"

We don't usually allow version constraints for packages in the registry.

Comment on lines +13 to +17
if (VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic")
set(SPARROW_IPC_BUILD_SHARED ON)
else()
set(SPARROW_IPC_BBUILD_SHARED OFF)
endif()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic")
set(SPARROW_IPC_BUILD_SHARED ON)
else()
set(SPARROW_IPC_BBUILD_SHARED OFF)
endif()
string(COMPARE EQUAL "${VCPKG_LIBRARY_LINKAGE}" "dynamic" SPARROW_IPC_BUILD_SHARED)

)

vcpkg_cmake_install()
vcpkg_cmake_config_fixup(PACKAGE_NAME sparrow-ipc CONFIG_PATH share/cmake/sparrow-ipc)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vcpkg_cmake_config_fixup(PACKAGE_NAME sparrow-ipc CONFIG_PATH share/cmake/sparrow-ipc)
vcpkg_cmake_config_fixup(CONFIG_PATH share/cmake/sparrow-ipc)

PACKAGE_NAME parameter is not necessary in this case.

@vicroms vicroms marked this pull request as draft April 8, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants