[sparrow-ipc] Create recipe and add version 1.0.0#51010
Draft
Alex-PLACET wants to merge 9 commits intomicrosoft:masterfrom
Draft
[sparrow-ipc] Create recipe and add version 1.0.0#51010Alex-PLACET wants to merge 9 commits intomicrosoft:masterfrom
Alex-PLACET wants to merge 9 commits intomicrosoft:masterfrom
Conversation
…ersion constraint
vicroms
requested changes
Apr 8, 2026
Comment on lines
+10
to
+11
| "name": "arcticdb-sparrow", | ||
| "version>=": "2.4.0" |
Member
There was a problem hiding this comment.
Suggested change
| "name": "arcticdb-sparrow", | |
| "version>=": "2.4.0" | |
| "name": "arcticdb-sparrow" |
We don't usually allow version constraints for packages in the registry.
Comment on lines
+13
to
+17
| if (VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic") | ||
| set(SPARROW_IPC_BUILD_SHARED ON) | ||
| else() | ||
| set(SPARROW_IPC_BBUILD_SHARED OFF) | ||
| endif() |
Member
There was a problem hiding this comment.
Suggested change
| if (VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic") | |
| set(SPARROW_IPC_BUILD_SHARED ON) | |
| else() | |
| set(SPARROW_IPC_BBUILD_SHARED OFF) | |
| endif() | |
| string(COMPARE EQUAL "${VCPKG_LIBRARY_LINKAGE}" "dynamic" SPARROW_IPC_BUILD_SHARED) |
| ) | ||
|
|
||
| vcpkg_cmake_install() | ||
| vcpkg_cmake_config_fixup(PACKAGE_NAME sparrow-ipc CONFIG_PATH share/cmake/sparrow-ipc) |
Member
There was a problem hiding this comment.
Suggested change
| vcpkg_cmake_config_fixup(PACKAGE_NAME sparrow-ipc CONFIG_PATH share/cmake/sparrow-ipc) | |
| vcpkg_cmake_config_fixup(CONFIG_PATH share/cmake/sparrow-ipc) |
PACKAGE_NAME parameter is not necessary in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner-Projectform.vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGEvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.