Merged
Conversation
Modernize, preparing for CMake 4.3.
BillyONeal
approved these changes
Mar 27, 2026
Member
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
Enable feature tests for targets which would conflict in normal CI: feature tests are isolated.
You know one of these days I need to read more closely. I just spent a bunch of time being like "uhh the conflict still exists look!"
CMake Error at ports/clapack/portfile.cmake:2 (message):
Can't build clapack if lapack-reference is installed. Please remove
lapack-reference:x64-windows, and try to install clapack:x64-windows again.... and now I see you already addressed that :( . At least I noticed before actually posting the foot-in-mouth comment.
|
|
||
| if(NOT TARGET lapack) | ||
| message(FATAL_ERROR "Target lapack was not created by find_package(clapack)!") | ||
| get_property(LAPACK_INCLUDE_DIR TARGET lapack PROPERTY INTERFACE_INCLUDE_DIRECTORIES) # Doesn't make much sense but ok. |
Member
There was a problem hiding this comment.
Review note: This used to be below so the "Doesn't make much sense but ok." comment that doesn't make much sense is the status quo.
No change requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize, preparing for CMake 4.3.
Move on from deprecated
IMPORTED_LINK_INTERFACE_LIBRARIESproperties, cf. #50497 (comment).Enable feature tests for targets which would conflict in normal CI: feature tests are isolated.