[vcpkg-tools] Update cmake to 4.2.3 by MauriceHubain-Cyncly · Pull Request #50497 · microsoft/vcpkg

MauriceHubain-Cyncly · 2026-03-16T13:42:11Z

This PR should fix all issues related to Visual Studio 2026 / 18.x, which is not supported by CMake 3.x.

It updates CMake to the latest stable release.

MauriceHubain-Cyncly · 2026-03-19T06:45:47Z

@microsoft-github-policy-service agree company="Cyncly"

dg0yt · 2026-03-21T04:04:21Z

The failing ports should be modified to fix the problems.

vicroms

Please fix or explain why these ports are being baselined.

MauriceHubain-Cyncly · 2026-03-24T08:06:21Z

I baselined following port-triplet combinations, because they failed in the first CI build for this PR.

faiss:arm64-windows=fail
sdl3-mixer:arm64-windows-static-md=fail
sdl3-mixer:x64-windows-release=fail
sdl3-mixer:x64-windows-static-md=fail
sdl3-mixer:x64-windows-static=fail
sdl3-mixer:x64-windows=fail
sdl3-mixer:x86-windows=fail
suitesparse-cholmod:arm64-windows-static-md=fail
suitesparse-cholmod:arm64-windows=fail
suitesparse-cholmod:x64-windows-static-md=fail
suitesparse-cholmod:x64-windows-static=fail
torch-th:x64-windows-static-md=fail

I can't check the arm64 issues, because I don't have access to such a system.

But I checked all windows triplets on my machine and they work as far as it could be expected.
For each test I cleaned the VCPKG worktree and binary cache:

git clean -dfx
rmdir /s /q "%LOCALAPPDATA%\vcpkg"
call bootstrap-vcpkg.bat -disableMetrics

vcpkg install faiss:x64-windows-release > ../log/faiss-x64-windows-release.log
-> All requested installations completed successfully

vcpkg install faiss:x64-windows-static-md > ../log/faiss-x64-windows-static-md.log
-> All requested installations completed successfully

vcpkg install faiss:x64-windows-static > ../log/faiss-x64-windows-static.log
-> All requested installations completed successfully

vcpkg install faiss:x64-windows > ../log/faiss-x64-windows.log
-> All requested installations completed successfully

vcpkg install faiss:x86-windows > ../log/faiss-x86-windows.log
-> faiss is only supported on '!x86 & !uwp', which does not match x86-windows.
-> expected failure

vcpkg install sdl3-mixer:x64-windows-release > ../log/sdl3-mixer-x64-windows-release.log
-> All requested installations completed successfully

vcpkg install sdl3-mixer:x64-windows-static-md > ../log/sdl3-mixer-x64-windows-static-md.log
-> All requested installations completed successfully

vcpkg install sdl3-mixer:x64-windows-static > ../log/sdl3-mixer-x64-windows-static.log
-> All requested installations completed successfully

vcpkg install sdl3-mixer:x64-windows > ../log/sdl3-mixer-x64-windows.log
-> All requested installations completed successfully

vcpkg install sdl3-mixer:x86-windows > ../log/sdl3-mixer-x86-windows.log
-> All requested installations completed successfully

vcpkg install suitesparse-cholmod:x64-windows-release > ../log/suitesparse-cholmod-x64-windows-release.log
-> All requested installations completed successfully

vcpkg install suitesparse-cholmod:x64-windows-static-md > ../log/suitesparse-cholmod-x64-windows-static-md.log
-> All requested installations completed successfully

vcpkg install suitesparse-cholmod:x64-windows-static > ../log/suitesparse-cholmod-x64-windows-static.log
-> All requested installations completed successfully

vcpkg install suitesparse-cholmod:x64-windows > ../log/suitesparse-cholmod-x64-windows.log
-> All requested installations completed successfully

vcpkg install suitesparse-cholmod:x86-windows > ../log/suitesparse-cholmod-x86-windows.log
-> All requested installations completed successfully

vcpkg install torch-th:x64-windows-release > ../log/torch-th-x64-windows-release.log
-> All requested installations completed successfully

vcpkg install torch-th:x64-windows-static-md > ../log/torch-th-x64-windows-static-md.log
-- Note: torch-th only supports dynamic library linkage. Building dynamic library.
-> expected failure

vcpkg install torch-th:x64-windows-static > ../log/torch-th-x64-windows-static.log
CMake Error at scripts/cmake/vcpkg_check_linkage.cmake:24 (message):
This port can only build as a dynamic library, but the triplet selects a
-> expected failure

vcpkg install torch-th:x64-windows > ../log/torch-th-x64-windows.log
-> All requested installations completed successfully

vcpkg install torch-th:x86-windows > ../log/torch-th-x86-windows.log
-> All requested installations completed successfully

I attach all detailed log files.

faiss-x64-windows-release.log
faiss-x64-windows-static-md.log
faiss-x64-windows-static.log
faiss-x64-windows.log
faiss-x86-windows.log
sdl3-mixer-x64-windows-release.log
sdl3-mixer-x64-windows-static-md.log
sdl3-mixer-x64-windows-static.log
sdl3-mixer-x64-windows.log
sdl3-mixer-x86-windows.log
suitesparse-cholmod-x64-windows-release.log
suitesparse-cholmod-x64-windows-static-md.log
suitesparse-cholmod-x64-windows-static.log
suitesparse-cholmod-x64-windows.log
suitesparse-cholmod-x86-windows.log
torch-th-x64-windows-release.log
torch-th-x64-windows-static-md.log
torch-th-x64-windows-static.log
torch-th-x64-windows.log
torch-th-x86-windows.log

For these test Visual Studio 18.4.1 was used.
I will rerun the same set of tests on another machine with Visual Studio 17.14.29.

MauriceHubain-Cyncly · 2026-03-24T17:17:49Z

The tests with Visual Studio 17.14.29 finished with the same results:

faiss-x64-windows.VS171429.log
faiss-x64-windows-release.VS171429.log
faiss-x64-windows-static.VS171429.log
faiss-x64-windows-static-md.VS171429.log
faiss-x86-windows.VS171429.log
sdl3-mixer-x64-windows.VS171429.log
sdl3-mixer-x64-windows-release.VS171429.log
sdl3-mixer-x64-windows-static.VS171429.log
sdl3-mixer-x64-windows-static-md.VS171429.log
sdl3-mixer-x86-windows.VS171429.log
suitesparse-cholmod-x64-windows.VS171429.log
suitesparse-cholmod-x64-windows-release.VS171429.log
suitesparse-cholmod-x64-windows-static.VS171429.log
suitesparse-cholmod-x64-windows-static-md.VS171429.log
suitesparse-cholmod-x86-windows.VS171429.log
torch-th-x64-windows.VS171429.log
torch-th-x64-windows-release.VS171429.log
torch-th-x64-windows-static.VS171429.log
torch-th-x64-windows-static-md.VS171429.log
torch-th-x86-windows.VS171429.log

dg0yt · 2026-03-24T20:38:54Z

I baselined following port-triplet combinations, because they failed in the first CI build for this PR.

Well, it might still mean it should be fixed as part of this PR.

I can't check the arm64 issues, because I don't have access to such a system.

You can access vcpkg CI logs.

But I checked all windows triplets on my machine and they work as far as it could be expected. ...

You must test the same feature set as in vcpkg CI to (maybe) reproduce the error.

MauriceHubain-Cyncly · 2026-03-25T07:07:31Z

I baselined following port-triplet combinations, because they failed in the first CI build for this PR.

Well, it might still mean it should be fixed as part of this PR.

I can't check the arm64 issues, because I don't have access to such a system.

You can access vcpkg CI logs.

But I checked all windows triplets on my machine and they work as far as it could be expected. ...

You must test the same feature set as in vcpkg CI to (maybe) reproduce the error.

I'll remove the unexpected entries from the ci.baseline.txt and give it another try.

dg0yt · 2026-03-26T05:41:01Z

arm64-windows: Both faiss and suitesparse-cholmod report unresolved symbols in lapack.lib which is provided by port clapack. AFAIU the symbols should be provided within port clapack by libf2c.lib.

clapack is quite dated, using a CMakeLists.txt with cmake_minimum_required(VERSION 2.6). Trouble with new versions of CMake can be expected.

suitesparse-cholmod reports in config log:

-- LAPACK libraries:    optimized;D:/installed/arm64-windows/lib/lapack.lib;debug;D:/installed/arm64-windows/debug/lib/lapack.lib;;
-- LAPACK include:      
-- LAPACK linker flags: optimized;D:/installed/arm64-windows/lib/lapack.lib;debug;D:/installed/arm64-windows/debug/lib/lapack.lib;;

I believe there should be also libf2c.lib here...

faiss reports in config log:

-- Found LAPACK: optimized;D:/installed/arm64-windows/lib/lapack.lib;debug;D:/installed/arm64-windows/debug/lib/lapack.lib
-- Using VCPKG FindLAPACK from package 'clapack'

No libf2c either.

libf2c should be injected by port clapack's vendored FindLAPACK.cmake. I see that it relies on the deprecated IMPORTED_LINK_INTERFACE_LIBRARIES_<CONFIG> properties. But the clapack-targets.cmake generated by the new CMake version has INTERFACE_LINK_LIBRARIES instead. And I could verify that the CMake update changed the exported config. Heads up, this will affect other ports, too - It just doesn't cause trouble until accessing properties directly.

I think it is better to revise port clapack first. I will try to find a few minutes but I cannot really promise much.

MauriceHubain-Cyncly · 2026-03-26T07:05:56Z

arm64-windows: Both faiss and suitesparse-cholmod report unresolved symbols in lapack.lib which is provided by port clapack. AFAIU the symbols should be provided within port clapack by libf2c.lib.

clapack is quite dated, using a CMakeLists.txt with cmake_minimum_required(VERSION 2.6). Trouble with new versions of CMake can be expected.

suitesparse-cholmod reports in config log:
-- LAPACK libraries:    optimized;D:/installed/arm64-windows/lib/lapack.lib;debug;D:/installed/arm64-windows/debug/lib/lapack.lib;;
-- LAPACK include:      
-- LAPACK linker flags: optimized;D:/installed/arm64-windows/lib/lapack.lib;debug;D:/installed/arm64-windows/debug/lib/lapack.lib;;
I believe there should be also libf2c.lib here...

faiss reports in config log:
-- Found LAPACK: optimized;D:/installed/arm64-windows/lib/lapack.lib;debug;D:/installed/arm64-windows/debug/lib/lapack.lib
-- Using VCPKG FindLAPACK from package 'clapack'
No libf2c either.

libf2c should be injected by port clapack's vendored FindLAPACK.cmake. I see that it relies on the deprecated IMPORTED_LINK_INTERFACE_LIBRARIES_<CONFIG> properties. But the clapack-targets.cmake generated by the new CMake version has INTERFACE_LINK_LIBRARIES instead. And I could verify that the CMake update changed the exported config. Heads up, this will affect other ports, too - It just doesn't cause trouble until accessing properties directly.

I think it is better to revise port clapack first. I will try to find a few minutes but I cannot really promise much.

Thanks for the support! :-)

dg0yt · 2026-03-26T08:43:22Z

clapack: #50727

MauriceHubain-Cyncly · 2026-04-01T13:23:37Z

@vicroms
Do I need to provide any additional information and changes for this PR?

dg0yt · 2026-04-01T17:10:17Z

scripts/ci.baseline.txt

 torch-th:arm64-linux=fail
 torch-th:arm64-windows-static-md=fail
 torch-th:arm64-windows=fail
+torch-th:x64-windows-static-md=fail # torch-th only supports dynamic library linkage


Suggested change

torch-th:x64-windows-static-md=fail # torch-th only supports dynamic library linkage

It will build a proper DLL in static-md configuration. Only static (= static CRT) makes it impossible to offer a DLL. But that line already exists.

vicroms · 2026-04-04T06:06:17Z

Closed and reopened to trigger CI against latest master.

alxvth · 2026-04-07T08:25:39Z

ltla-powerit seems to be the only failing port left here. That failure is unrelated to this PR and should be fixed with #51009.

MauriceHubain-Cyncly force-pushed the MHC/cmake_4_2_3 branch from 028a291 to e8db864 Compare March 18, 2026 07:16

MauriceHubain-Cyncly marked this pull request as ready for review March 19, 2026 06:46

This was referenced Mar 20, 2026

VCPKG Visual Studio 2026 fail #49361

Open

[vcpkg-scripts] Update to CMake 4.2 #48511

Draft

vicroms reviewed Mar 24, 2026

View reviewed changes

vicroms marked this pull request as draft March 24, 2026 05:56

MauriceHubain-Cyncly requested a review from vicroms March 24, 2026 17:18

MauriceHubain-Cyncly force-pushed the MHC/cmake_4_2_3 branch from e8db864 to 6d18c70 Compare March 25, 2026 07:07

dg0yt mentioned this pull request Mar 26, 2026

[clapack] Revise #50727

Merged

MauriceHubain-Cyncly force-pushed the MHC/cmake_4_2_3 branch 2 times, most recently from b4a77b6 to 18407a4 Compare March 31, 2026 10:51

MauriceHubain-Cyncly marked this pull request as ready for review March 31, 2026 19:33

dg0yt reviewed Apr 1, 2026

View reviewed changes

MauriceHubain-Cyncly force-pushed the MHC/cmake_4_2_3 branch from 18407a4 to 828a62e Compare April 2, 2026 06:55

vicroms closed this Apr 4, 2026

vicroms reopened this Apr 4, 2026

alxvth mentioned this pull request Apr 7, 2026

[ltla-subpar] Devendor ltla-sanisizer #51009

Merged

7 tasks

MauriceHubain-Cyncly force-pushed the MHC/cmake_4_2_3 branch from 828a62e to 19ab6a4 Compare April 8, 2026 07:28

MauriceHubain-Cyncly force-pushed the MHC/cmake_4_2_3 branch 2 times, most recently from b8d437a to 18b635b Compare April 8, 2026 14:43

dg0yt mentioned this pull request Apr 9, 2026

[trieste] Do not take generic artifact names #51049

Merged

MauriceHubain-Cyncly force-pushed the MHC/cmake_4_2_3 branch from 18b635b to a5fb641 Compare April 9, 2026 05:33

MauriceHubain-Cyncly marked this pull request as draft April 9, 2026 07:14

MauriceHubain-Cyncly marked this pull request as ready for review April 9, 2026 07:14

MauriceHubain-Cyncly force-pushed the MHC/cmake_4_2_3 branch from a5fb641 to 29d6756 Compare April 9, 2026 10:15

[vcpkg-tools] Update cmake to 4.2.3

29d6756

Conversation

MauriceHubain-Cyncly commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MauriceHubain-Cyncly commented Mar 19, 2026

Uh oh!

dg0yt commented Mar 21, 2026

Uh oh!

vicroms left a comment

Choose a reason for hiding this comment

Uh oh!

MauriceHubain-Cyncly commented Mar 24, 2026

Uh oh!

MauriceHubain-Cyncly commented Mar 24, 2026

Uh oh!

dg0yt commented Mar 24, 2026

Uh oh!

MauriceHubain-Cyncly commented Mar 25, 2026

Uh oh!

dg0yt commented Mar 26, 2026

Uh oh!

MauriceHubain-Cyncly commented Mar 26, 2026

Uh oh!

dg0yt commented Mar 26, 2026

Uh oh!

MauriceHubain-Cyncly commented Apr 1, 2026

Uh oh!

dg0yt Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

vicroms commented Apr 4, 2026

Uh oh!

alxvth commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MauriceHubain-Cyncly commented Mar 16, 2026 •

edited

Loading