Skip to content

If url is over 2083 characters, change it from get to post and send#13

Open
tgyou wants to merge 6 commits into
matheuss:masterfrom
tgyou:master
Open

If url is over 2083 characters, change it from get to post and send#13
tgyou wants to merge 6 commits into
matheuss:masterfrom
tgyou:master

Conversation

@tgyou

@tgyou tgyou commented Apr 7, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@jacksteamdev jacksteamdev mentioned this pull request May 6, 2017
@JukeboxRhino

Copy link
Copy Markdown
Collaborator

@tgyou If you could fix the linter errors I can merge this. https://travis-ci.org/matheuss/google-translate-api/jobs/219561271

@tgyou

tgyou commented Nov 9, 2017

Copy link
Copy Markdown
Contributor Author

I am really sorry. I checked it now.
I merged the latest master, and changed it correctly to the lint syntax.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.9%) to 90.0% when pulling 71ab274 on tgyou:master into 777d7db on matheuss:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.9%) to 90.0% when pulling 9239e08 on tgyou:master into 777d7db on matheuss:master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.9%) to 90.0% when pulling 9239e08 on tgyou:master into 777d7db on matheuss:master.

@codecov-io

codecov-io commented Nov 9, 2017

Copy link
Copy Markdown

Codecov Report

Merging #13 into master will increase coverage by 0.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   92.42%   92.85%   +0.43%     
==========================================
  Files           2        2              
  Lines          66       70       +4     
==========================================
+ Hits           61       65       +4     
  Misses          5        5
Impacted Files Coverage Δ
index.js 90.9% <100%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777d7db...26a570d. Read the comment docs.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.9%) to 90.0% when pulling 622982d on tgyou:master into 777d7db on matheuss:master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.9%) to 90.0% when pulling 622982d on tgyou:master into 777d7db on matheuss:master.

@coveralls

coveralls commented Nov 9, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+1.9%) to 92.857% when pulling 26a570d on tgyou:master into 777d7db on matheuss:master.

@jacksteamdev jacksteamdev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jacksteamdev

Copy link
Copy Markdown

@JukeboxRhino What do you think about merging this?

@JukeboxRhino JukeboxRhino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants