Repository navigation
Object gen fixed seed #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
amartyads
wants to merge
5
commits into
ls1mardyn:master
Choose a base branch
from
amartyads:objectGenFixedSeed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ffc7da9
Add option to manually specify initial seed
amartyads 35e47bd
Documentation
amartyads f317079
Option for drift removal
amartyads ba6e5f6
Since removeDrift works on the whole particle container, moving it to…
amartyads 37bea07
Correction to XML reading
amartyads File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,14 +24,19 @@ class ObjectGenerator : public InputBase { | |
| ObjectGenerator() : _filler(nullptr), _object(nullptr), _velocityAssigner(nullptr), _moleculeIdPool(nullptr) {}; | ||
|
|
||
| /** @brief Read in XML configuration for ObjectGenerator and all its included objects. | ||
| * | ||
| * The velocityAssigner can take two additional parameters. enableRandomSeed adds the option of having random | ||
| * intial molecule velocities at the beginning of the simulation. If a seed is specified, that value is used | ||
| * instead. Leaving both blank gives the default behaviour (seed = 0). Both cannot be nonzero simultaneously. | ||
| * | ||
| * The following XML object structure is handled by this method: | ||
| * @note This structure is not fixed yet and may see changes | ||
| * \code{.xml} | ||
| <objectgenerator> | ||
| <filler type="STRING"> <!-- see Filler documentation --> </filler> | ||
| <object type="STRING"> <!-- see Object documentation --> </object> | ||
| <velocityAssigner type="STRING"> <!-- see VelocityAssignerBase documentation --> </velocityAssigner> | ||
| <velocityAssigner type="STRING" enableRandomSeed="BOOL" seed="LONG"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps one could also add a comment here to indicate that |
||
| <!-- see VelocityAssignerBase documentation --> </velocityAssigner> | ||
| </objectgenerator> | ||
| \endcode | ||
| */ | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it makes sense to multiply
fixedSeedby 1k to keep the ranks “visible” in the decimal representation for debugging purposes?