Repository navigation
Conversation
amartyads
marked this pull request as draft
October 5, 2026 22:29
rubenhorn
previously approved these changes
Oct 6, 2026
rubenhorn
left a comment
rubenhorn
left a comment
Contributor
There was a problem hiding this comment.
LGTM. (2 comments are just minor ideas)
| <filler type="STRING"> <!-- see Filler documentation --> </filler> | ||
| <object type="STRING"> <!-- see Object documentation --> </object> | ||
| <velocityAssigner type="STRING"> <!-- see VelocityAssignerBase documentation --> </velocityAssigner> | ||
| <velocityAssigner type="STRING" enableRandomSeed="BOOL" seed="LONG"> |
Contributor
There was a problem hiding this comment.
Perhaps one could also add a comment here to indicate that enableRandomSeed and seed are mutually exclusive.
|
|
||
| } else { | ||
| } else if(fixedSeed != 0) { | ||
| return fixedSeed + _simulation.domainDecomposition().getRank(); |
Contributor
There was a problem hiding this comment.
Do you think it makes sense to multiply fixedSeed by 1k to keep the ranks “visible” in the decimal representation for debugging purposes?
… a more sensible XML location
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this PR, I'm adding the possibility of fixed seeds in the MultiObjectGenerator.
How Has This Been Tested?
Options tested, corner cases checked
The reason I'm adding the rank to the seed is because of MaMiCo, but also because I came across this commit, which has been removed in #377 . I can't see anything that would cause it to become unnecessary when using the EqualVelocityAssigner. Maybe I'm missing something. But I did approve the PR, and I assume it was checked back then, that this effect did not occur, or was ultimately not important (equilibration should take care of it eventually anyway).
Documentation
all-options.xmldocuments how to use the feature. (There's no corresponding entry in all-options to update)readXML()documents how to use the feature.