Skip to content

fix(cli): validate migration name and correctly report created migration files #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joanagmaia merged 3 commits into from
May 14, 2026
+18 −8
Merged

fix(cli): validate migration name and correctly report created migration files #4103

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a32a0f3
fix(cli): validate migration name and correctly report created migrat…
Muawiya-contact May 11, 2026
b25c2c3
Merge branch 'main' into fix/migrations-cli
Muawiya-contact May 13, 2026
7fa0b52
Merge branch 'main' into fix/migrations-cli
joanagmaia May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions scripts/cli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,23 +293,33 @@ function build() {
}

function create_migration() {
MIG_NAME="$1"
MIG_NAME="$(printf '%s\n' "$1" | tr -s ' ' | xargs)"
Comment thread
Muawiya-contact marked this conversation as resolved.
if [[ -z "$MIG_NAME" ]] || [[ ! "$MIG_NAME" =~ ^[A-Za-z0-9_-]+$ ]]; then
Comment thread
Muawiya-contact marked this conversation as resolved.
error "Migration name must be non-empty and contain only letters, numbers, underscores, or hyphens"
exit 1
Comment thread
Muawiya-contact marked this conversation as resolved.
fi

MIG_VERSION=$(date +%s)
UP_MIG_FILE="${CLI_HOME}/../backend/src/database/migrations/V${MIG_VERSION}__${MIG_NAME}.sql"
DOWN_MIG_FILE="${CLI_HOME}/../backend/src/database/migrations/U${MIG_VERSION}__${MIG_NAME}.sql"
touch $UP_MIG_FILE
touch $DOWN_MIG_FILE
yell "Created ${MIG_FILE}"
touch "$UP_MIG_FILE"
touch "$DOWN_MIG_FILE"
yell "Created $UP_MIG_FILE and $DOWN_MIG_FILE"
}

function create_product_migration() {
MIG_NAME="$1"
MIG_NAME="$(printf '%s\n' "$1" | tr -s ' ' | xargs)"
if [[ -z "$MIG_NAME" ]] || [[ ! "$MIG_NAME" =~ ^[A-Za-z0-9_-]+$ ]]; then
error "Migration name must be non-empty and contain only letters, numbers, underscores, or hyphens"
exit 1
Comment thread
Muawiya-contact marked this conversation as resolved.
fi

MIG_VERSION=$(date +%s)
UP_MIG_FILE="${CLI_HOME}/../backend/src/product/migrations/V${MIG_VERSION}__${MIG_NAME}.sql"
DOWN_MIG_FILE="${CLI_HOME}/../backend/src/product/migrations/U${MIG_VERSION}__${MIG_NAME}.sql"
touch $UP_MIG_FILE
touch $DOWN_MIG_FILE
yell "Created ${MIG_FILE}"
touch "$UP_MIG_FILE"
touch "$DOWN_MIG_FILE"
yell "Created $UP_MIG_FILE and $DOWN_MIG_FILE"
}

function build_and_publish() {
Expand Down
Loading