fix(cli): validate migration name and correctly report created migration files

[Muawiya-contact]

Problem

Two bugs in scripts/cli migration helpers:

1. $MIG_FILE is printed in final output but never defined
2. No validation when migration name argument is empty,
   silently creates broken files like V123456__ .sql
3. File paths not quoted in touch calls

Fix

• Added empty name validation with error + exit in both functions
• Quoted $UP_MIG_FILE and $DOWN_MIG_FILE in touch calls
• Fixed output message to show actual created filenames

Files Changed

• scripts/cli

Closes #4102

---

Note

Low Risk
Low risk: small bash-script hardening for migration file creation (input validation, quoting, and log output) with no runtime impact beyond rejecting invalid names.

Overview
Tightens the scripts/cli migration helpers by trimming/normalizing the provided migration name, rejecting empty/invalid names, and exiting with a clear error.

Fixes migration file creation by quoting touch paths and updating the output to print the actual UP_MIG_FILE/DOWN_MIG_FILE names instead of an undefined variable.

^{Reviewed by Cursor Bugbot for commit 7fa0b52. Bugbot is set up for automated code reviews on this repo. Configure here.}

[Copilot]

Pull request overview

This PR fixes issues in the scripts/cli migration helper commands by adding basic argument validation and correcting the final “created” output so it reports the actual migration files created.

Changes:

• Add required-argument validation for migration name in create_migration() and create_product_migration().
• Quote migration file paths in touch calls to handle paths safely.
• Fix the final output message to reference $UP_MIG_FILE and $DOWN_MIG_FILE (instead of undefined $MIG_FILE).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[Muawiya-contact]

Hi @gaspergrom, @joanagmaia, @themarolt 👋

Just a friendly ping — this PR fixes two bugs in the migration CLI helpers (undefined variable output + missing input validation). It's a low-risk, single-file shell script change.

Would love to get your eyes on it when you have a moment. Happy to make any adjustments if needed!

Thanks 🙏

[themarolt]

@Muawiya-contact - the change looks ok - it would fail anyway later on with flyway but it's good that it can be prevented here as well - please merge main branch so it's ok to merge. cc @joanagmaia

[Muawiya-contact]

@themarolt thanks for your honest feedback, I have merged the main branch on it. Can you take a look at it, #4075 please?
Thanks 🫶

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

scripts/cli:312

• Same issue as create_migration(): xargs will strip quotes/backslashes during parsing, so an invalid migration name may be altered into a valid one and pass validation. Prefer trimming with Bash string ops (or sed) without shell-style parsing semantics, then validate.

    MIG_NAME="$(printf '%s\n' "$1" | tr -s ' ' | xargs)"
    if [[ -z "$MIG_NAME" ]] || [[ ! "$MIG_NAME" =~ ^[A-Za-z0-9_-]+$ ]]; then

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Reviewed by Cursor Bugbot for commit 7fa0b52. Configure here.}