Skip to content

fix(twake-mui): Readable label on a primary Fab in dark mode #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JF-Cozy merged 2 commits into from
Nov 2, 2026
Merged

fix(twake-mui): Readable label on a primary Fab in dark mode #192

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15dcf5b
fix(twake-mui): Readable label on a primary Fab in dark mode
Oct 22, 2026
05f0526
chore(twake-mui): Drop the comment on the dark primary Fab
Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/twake-mui/src/lib/overrides.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,6 +1181,11 @@ export const overrides: NonNullable<ThemeOptions['components']> = {
primary: ({ theme }) => ({
color: theme.vars.palette.primary.dark,
backgroundColor: theme.vars.palette.primary.light,
// The dark palette's primary.dark is a light blue: 1.9:1 on
// primary.light. Its contrastText (dark grey) gives 5.7:1
Comment thread
9clg6 marked this conversation as resolved.
Resolved
...theme.applyStyles('dark', {
color: theme.vars.palette.primary.contrastText
}),
'&:hover': {
backgroundColor: `color-mix(in srgb, ${theme.vars.palette.primary.light}, #000 5%)`
},
Expand Down
Loading