Repository navigation
fix(twake-mui): Readable label on a primary Fab in dark mode - #192
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
9clg6
force-pushed
the
fix/fab-primary-dark
branch
from
October 22, 2026 21:17
c012195 to
15dcf5b
Compare
9clg6
changed the title
Collaborator
|
@9clg6 did you checked with @swanndesign25 ? Besides we should avoid theme exception as much as possible, maybe one var could be ok for both light/dark. I'll ask Swann and go back to you 👍 BTW we must also update cozy-ui the same way. |
JF-Cozy
approved these changes
Oct 26, 2026
Author
|
Same fix for cozy-ui: cozy/cozy-ui#2969 |
9clg6
force-pushed
the
fix/fab-primary-dark
branch
from
November 2, 2026 08:18
46dca5f to
05f0526
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the dark scheme, a primary Fab drew
primary.dark(#46a2ff) onprimary.light(#bfdfff): 1.9:1, the label is almost invisible (e.g. the feedback button of @linagora/twake-feedback, linagora/twake-space-chat#566). In dark mode the label now takesprimary.contrastText(90% Grey 900): 5.7:1, 5.2:1 on hover. Light mode is unchanged. The dark modes of the argos Fab story show it.