mod: update to btcd v2 modules#282
Closed
ellemouton wants to merge 1 commit into
Closed
Conversation
Bump btcd to v0.26.0 and adopt its new per-package v2 modules: wire/v2, txscript/v2, chaincfg/v2, chainhash/v2, btcutil/v2, psbt/v2, and btcec/v2 v2.5.0. The address symbols that moved out of btcutil into the new address package (DecodeAddress, the Address types and the NewAddress* constructors) are imported as btcaddr to avoid shadowing by local "address" variables. The migrated dependencies are now pinned to their released tags: lnd master (post btcd-v2), btcwallet v0.18.0, neutrino v0.18.0, and lightning-onion v1.4.0. btcec/v2 v2.5.0 requires Go 1.25, so the Go version is bumped to 1.25.11.
e75f911 to
23b4dd6
Compare
Member
Author
|
Combined into #280 for easier review — that PR now carries both the btcd v2 module migration and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
lndclientto the new per-packagev2modules introduced bybtcdv0.26.0. The monolithicbtcdpackages (wire,txscript,chaincfg,chainhash,btcutil,psbt) were split out into their own/v2modules, and the address-handling symbols moved out ofbtcutilinto a new
addresspackage.Changes
btcdtov0.26.0and adopt thev2modules:wire/v2,txscript/v2,chaincfg/v2,chainhash/v2,btcutil/v2,psbt/v2,and
btcec/v2 v2.5.0.btcutilinto the newaddresspackage (
DecodeAddress, theAddresstypes, theNewAddress*constructors) are imported as
btcaddrto avoid shadowing by localaddressvariables.btcec/v2 v2.5.0requires Go 1.25, so thegodirective is bumped to1.25.11.Dependencies
Until the migrated modules are tagged, the dependency chain is pulled in
via temporary
replacedirectives:btcdv0.26.0(tagged)lightningnetwork/lnd(btcd v2 migration)btcsuite/btcwallet(btcd v2 migration)lightninglabs/neutrino(btcd v2 migration)lightningnetwork/lightning-onion(btcd v2 migration)Once those are tagged the
replacedirectives will be dropped and thego.modpinned to the released versions.Warning
Draft — do not merge until the upstream dependencies above are tagged.