Skip to content

fix: remove the copper lid at the top of the re-entrance tube #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
h0t5tuff wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: remove the copper lid at the top of the re-entrance tube #142

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
920606f
fix: remove the copper lid at the top of the re-entrance tube
h0t5tuff Oct 12, 2026
5a558ec
make the 'lid' actually flat
ManuelHu Oct 13, 2026
dfdd859
Merge branch 'legend-exp:main' into fix/rt-top-lid
h0t5tuff Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/pygeoml1000/rt_profiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,17 +304,19 @@ def make_inner_profile(
if r == 0:
# Skip r=0 points during iteration - closures added separately
continue
# Keep the argon a protection gap below the top face of its copper mother
inner_z_value = z - PROTECTION_GAP_POLYCONE if z_original == top_z_original else z
if r == neck_radius:
# Cylindrical section
inner_r_value = max(0, r - thickness)
inner_z.append(z)
inner_z.append(inner_z_value)
inner_r.append(inner_r_value)
else:
# Curved section - scale thickness by radius ratio
radius_ratio = r / neck_radius
scaled_thickness = thickness * radius_ratio
inner_r_value = max(0, r - scaled_thickness)
inner_z.append(z)
inner_z.append(inner_z_value)
inner_r.append(inner_r_value)

# Add closures explicitly
Expand All @@ -325,9 +327,9 @@ def make_inner_profile(
inner_z.insert(0, inner_bottom_z)
inner_r.insert(0, 0)

# Top closure with 6 mm thickness at the top
top_thickness = _steel_thickness_from_top(0, tube_height) # 6.0 mm at the top
inner_z.append(top_z_original - 5000 - top_thickness)
# Top closure: the tube is open at the top (the lock is not modelled yet), so close
# the argon only a protection gap below the top, leaving only a minor copper lid there.
inner_z.append(top_z_original - 5000 - PROTECTION_GAP_POLYCONE)
inner_r.append(0)

# Ensure proper closure with intermediate points
Expand Down
Loading