Repository navigation
Conversation
avoiding a point-wise surface overlap
Collaborator
|
I think at some point we really have to refactor this module since it is getting really difficult to understand what is going on (at least to me :D ). Your PR seems good to me though. |
Member
|
@h0t5tuff have you validated this? can you provide a plot that demonstrates the fix? |
Author
@gipert Yep, plot attached: top 10 mm of the tube, before vs after (this PR), with 1000 geantino vtxs sampled uniformly in reentrance_tube_copper. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The underground argon closed 6 mm below the re-entrance tube’s top, leaving a 55.5 kg copper lid in reentrance_tube_copper. this is an artifact of how the argon profile is made: the tube is open at the top. The argon now closes 1 µm (PROTECTION_GAP_POLYCONE) below the top, so the lid is about 20 g. Only one GDML point changes; I also tested with Geant4’s overlap check and it passed