Skip to content

Make jdk better at finding versions #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tewaro wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make jdk better at finding versions #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions test/benchmark/common/prepare_host.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,36 @@ prepare_fs() {

JDK_URL="https://download.oracle.com/java/25/latest/jdk-25_linux-x64_bin.tar.gz"
MVN_URL="https://archive.apache.org/dist/maven/maven-3/3.9.12/binaries/apache-maven-3.9.12-bin.tar.gz"
export MVN_DIR=$(realpath ".cache/apache-maven-3.9.12")
export YCSB_PATH=$(realpath ".cache/ycsb")
export JDK_PATH=$(realpath ".cache/jdk-25.0.2")
export CACHE_DIR=$(realpath -m ".cache")
export MVN_DIR=$(realpath -m "${CACHE_DIR}/apache-maven-3.9.12")
export YCSB_PATH=$(realpath -m "${CACHE_DIR}/ycsb")
resolve_jdk_path() {
shopt -s nullglob
local jdk_dirs=("${CACHE_DIR}"/jdk-*)
shopt -u nullglob

if [ ${#jdk_dirs[@]} -eq 0 ]; then
return 1
fi

local latest_jdk
latest_jdk=$(printf '%s\n' "${jdk_dirs[@]}" | sort -V | tail -n 1)
Copy link
Copy Markdown
Contributor

@arthurp arthurp Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems really complicated for what it does. Why not latest_jdk=$(ls -1 "${CACHE_DIR}"/jdk-* | sort -V | tail -n 1) (with nullglob as you astutely included, I didn't know that existed) and then just

if [ -z "$latest_jdk" ]; then
    return 1
fi

for the error check.

realpath "$latest_jdk"
}

export JDK_PATH=$(resolve_jdk_path || true)
Copy link
Copy Markdown
Contributor

@arthurp arthurp Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this set here, and then again in prepare_ycsb?

export JAVA_HOME=$JDK_PATH


prepare_ycsb() {
mkdir -p .cache
(
cd .cache
if [ ! -d "$JDK_PATH" ]; then
wget "$JDK_URL" -O jdk.tar.gz
tar -xvf ./jdk.tar.gz
export JDK_PATH=$(resolve_jdk_path)
export JAVA_HOME=$JDK_PATH
fi

if [ ! -d "$MVN_DIR" ]; then
Expand All @@ -72,6 +90,10 @@ prepare_ycsb() {
git clone https://github.com/tewaro/YCSB.git -b tewaro/quickfix-coreworkload-deletes-master --depth=1 $YCSB_PATH

# Build
if [ ! -x "$JAVA_HOME/bin/java" ]; then
echo "Invalid JAVA_HOME: $JAVA_HOME" >&2
exit 1
fi
pushd $YCSB_PATH
$MVN_DIR/bin/mvn -pl site.ycsb:redis-binding -am clean package
$MVN_DIR/bin/mvn -pl site.ycsb:memcached-binding -am clean package
Expand Down
Loading