Make jdk better at finding versions#235
Open
tewaro wants to merge 1 commit into
Open
Conversation
jdk-25 has gone up a minor version number, just fix prepare_ycsb to adopt whatever the minor version is by doing with little bit of shell scripting.
arthurp
approved these changes
Jun 5, 2026
Contributor
arthurp
left a comment
arthurp
left a comment
There was a problem hiding this comment.
Hopefully this will change/go away once we are in the new benchmark last, but this is reasonable.
Also, I'm amused and you of all people are making the build less reproducible. :-D You can have your Nix later, I guess.
| realpath "$latest_jdk" | ||
| } | ||
|
|
||
| export JDK_PATH=$(resolve_jdk_path || true) |
Contributor
There was a problem hiding this comment.
Why is this set here, and then again in prepare_ycsb?
| fi | ||
|
|
||
| local latest_jdk | ||
| latest_jdk=$(printf '%s\n' "${jdk_dirs[@]}" | sort -V | tail -n 1) |
Contributor
There was a problem hiding this comment.
This seems really complicated for what it does. Why not latest_jdk=$(ls -1 "${CACHE_DIR}"/jdk-* | sort -V | tail -n 1) (with nullglob as you astutely included, I didn't know that existed) and then just
if [ -z "$latest_jdk" ]; then
return 1
fi
for the error check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jdk-25 has gone up a minor version number, just fix prepare_ycsb to adopt whatever the minor version is by doing with little bit of shell scripting.