Skip to content

[quality] fix: remove duplicate TestGetProjectDashboards_KnownProject breaking CI #19952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clubanderson merged 1 commit into from
Jun 29, 2026
Merged

[quality] fix: remove duplicate TestGetProjectDashboards_KnownProject breaking CI #19952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 2 additions & 23 deletions pkg/api/projects_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,8 @@ package api

import "testing"

func TestGetProjectDashboards_KnownProject(t *testing.T) {
dashboards := getProjectDashboards("kubestellar")
if dashboards == nil {
t.Fatal("expected non-nil dashboard list for 'kubestellar' project")
}
if len(dashboards) == 0 {
t.Fatal("expected non-empty dashboard list for 'kubestellar' project")
}
// Verify key dashboards are present
required := []string{"dashboard", "clusters", "compliance", "security", "workloads"}
for _, r := range required {
found := false
for _, d := range dashboards {
if d == r {
found = true
break
}
}
if !found {
t.Errorf("expected dashboard %q in kubestellar presets, not found", r)
}
}
}
// TestGetProjectDashboards_KnownProject lives in buildinfo_test.go (PR #17363).
// The additional cases below cover edge cases not in that test.
Comment on lines +5 to +6

func TestGetProjectDashboards_UnknownProject(t *testing.T) {
dashboards := getProjectDashboards("nonexistent-project")
Expand Down
Loading