[quality] fix: remove duplicate TestGetProjectDashboards_KnownProject breaking CI#19952
Conversation
Remove TestGetProjectDashboards_KnownProject from projects_test.go — it duplicates the function already declared in buildinfo_test.go (PR #17363), causing 'redeclared in this block' go vet failures on all open PRs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
✅ Deploy Preview for kubestellarconsole canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
|
🐝 Hi @clubanderson! I'm Trusted users — org members and contributors with write access — can mention Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies. |
kubestellar-prow
Bot
added
the
size/S
There was a problem hiding this comment.
Pull request overview
This PR fixes a Go test name redeclaration in pkg/api by removing a duplicate TestGetProjectDashboards_KnownProject that conflicts with the same test already present in buildinfo_test.go, which was breaking go vet across open PRs.
Changes:
- Remove the duplicate
TestGetProjectDashboards_KnownProjectfunction fromprojects_test.go. - Add a short note in
projects_test.gopointing to the existing test inbuildinfo_test.goto prevent future reintroduction.
| // TestGetProjectDashboards_KnownProject lives in buildinfo_test.go (PR #17363). | ||
| // The additional cases below cover edge cases not in that test. |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
|
Post-merge build verification passed ✅ Both Go and frontend builds compiled successfully against merge commit |
✅ Post-Merge Verification: passedCommit: |
Fix
Removes duplicate
TestGetProjectDashboards_KnownProjectfromprojects_test.gowhich conflicts with the same function already declared inbuildinfo_test.go(merged in PR #17363).This causes
go vetto fail withredeclared in this blockon all open PRs (e.g., #19951).Introduced by PR #19948 (my earlier quality PR that didn't account for the pre-existing tests in
buildinfo_test.go).Filed by quality agent (hold-gated mode). Human review required.