Skip to content

Feature/typo3 9 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BFallert wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/typo3 9 #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba23499
Update composer.json
BFallert Jul 13, 2020
260da1f
add missing important information in composer.json
BFallert Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,36 @@
"name": "kitodo/presentation_package",
"type": "typo3-cms-extension",
"description": "Template Package for Kitodo Presentation",
"homepage": "https://www.effective-webwork.de/",
"homepage": "https://presentation-demo.kitodo.org/",
"readme": "README.md",
"license": "GPL-3.0-or-later",
"keywords": ["TYPO3 CMS"],
"version": "1.0.0",
Copy link
Copy Markdown
Member

@stweil stweil Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the version still required (and also useful)?

"keywords": ["TYPO3 CMS", "Kitodo", "Kitodo Demo Presentation Package"],
Copy link
Copy Markdown
Member

@stweil stweil Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Kitodo Demo Presentation Package" is too long for a keyword.

"require": {
"typo3/cms": "^8.7",
"solarium/solarium": "^4.0"
"typo3/cms-core": "~9.5.26",
Copy link
Copy Markdown
Member

@stweil stweil Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request adds the missing dependency on kitodo/presentation which depends on TYPO3. Therefore it should no longer be necessary to add the dependency on TYPO3 here.

"kitodo/presentation": ">=3.0.0"
},
"authors": [
{
"name": "Christopher Timm",
"role": "developer",
"email": "timm@effective-webwork.de",
"homepage": "https://www.effective-webwork.de/"
},
{
"name": "Meyer, Sebastian",
"role": "maintainer",
"email": "sebastian@informathekar.de",
"homepage": "https://www.slub-dresden.de"
}
],
"autoload": {
"psr-4": {
"Kitodo\\presentation_package\\": "Classes/"
}
},
"extra": {
"typo3/cms": {
"extension-key": "presentation_package"
}
}
}
}