Feature/typo3 9#29
Open
BFallert wants to merge 2 commits into
Open
Conversation
add ^9.5 to typ3/cms
It is missing crucial information like dependencies and TER constraints (see https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ExtensionArchitecture/ComposerJson/Index.html).
|
Kudos, SonarCloud Quality Gate passed!
|
stweil
suggested changes
Mar 24, 2025
| "require": { | ||
| "typo3/cms": "^8.7", | ||
| "solarium/solarium": "^4.0" | ||
| "typo3/cms-core": "~9.5.26", |
Member
There was a problem hiding this comment.
The pull request adds the missing dependency on kitodo/presentation which depends on TYPO3. Therefore it should no longer be necessary to add the dependency on TYPO3 here.
| "license": "GPL-3.0-or-later", | ||
| "keywords": ["TYPO3 CMS"], | ||
| "version": "1.0.0", | ||
| "keywords": ["TYPO3 CMS", "Kitodo", "Kitodo Demo Presentation Package"], |
Member
There was a problem hiding this comment.
"Kitodo Demo Presentation Package" is too long for a keyword.
| "readme": "README.md", | ||
| "license": "GPL-3.0-or-later", | ||
| "keywords": ["TYPO3 CMS"], | ||
| "version": "1.0.0", |
Member
There was a problem hiding this comment.
Isn't the version still required (and also useful)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add missing important information in composer.json