Add support for parameter store authentication#7572
Add support for parameter store authentication#7572stegojulia wants to merge 7 commits intokedacore:mainfrom
Conversation
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
|
| Status | Scan Engine |  Critical |
 High |
 Medium |
 Low |
Total (0) |
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
| // +kubebuilder:validation:MinItems=1 | ||
| Parameters []AwsParameterStoreParameter `json:"parameters"` | ||
| // +optional | ||
| Credentials *AwsParameterStoreCredentials `json:"credentials"` |
There was a problem hiding this comment.
Should omitempty appear here too?
There was a problem hiding this comment.
I believe omitempty isn't needed for pointers, same pattern is used for here
There was a problem hiding this comment.
Could you include the line number in the reference, so I can check exactly which one you mean?
There was a problem hiding this comment.
whoops sorry I thought I had, here it is https://github.com/stegojulia/keda/blob/3a66e4f91dbd340a4e06b262f5cd6396c325373b/apis/keda/v1alpha1/triggerauthentication_types.go#L409
There was a problem hiding this comment.
Ah, check. I only know that part from the API convention for using that:
| // +optional | ||
| Credentials *AwsParameterStoreCredentials `json:"credentials"` | ||
| // +optional | ||
| PodIdentity *AuthPodIdentity `json:"podIdentity"` |
There was a problem hiding this comment.
Should omitempty appear here too?
There was a problem hiding this comment.
I believe omitempty isn't needed for pointers, same pattern is used for here
| Parameter string `json:"parameter"` | ||
| Name string `json:"name"` | ||
| // +optional | ||
| WithDecryption *bool `json:"withDecryption,omitempty"` |
There was a problem hiding this comment.
Can you add here a comment to clarify what omitting WithDecryption (leaving it nil) means? Users likely need to set this to true to get the plaintext, right?
stegojulia
force-pushed
the
paramstore
branch
2 times, most recently
from
29068c9 to
089c265
Compare
rickbrouwer
added
merge-conflict
stegojulia
force-pushed
the
paramstore
branch
2 times, most recently
from
548b0de to
aca39e8
Compare
Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>
Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>
Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>
Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>
Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>
Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>
Signed-off-by: Julia Jablonska <julia.jablonska@zestia.com>
2 participants
Provide a description of what has been changed
Checklist
make generate-scalers-schemahas been run to update any outdated generated filesFixes #6311
Relates to #840 and #1725