Explain withDecryption arg

Author: stegojulia

apis/keda/v1alpha1/triggerauthentication_types.go

@@ -424,6 +424,10 @@ type AwsParameterStoreValue struct {
 	ValueFrom ValueFromSecret `json:"valueFrom"`
 }
 
+// WithDecryption defaults to true if not specified.
+// For SecureString parameters, this must be true to retrieve the plaintext value.
+// Set to false for SecureString parameters to retrieve the encrypted value.
+// For String parameters, this setting has no effect.
 type AwsParameterStoreParameter struct {
 	Parameter string `json:"parameter"`
 	Name      string `json:"name"`

pkg/scaling/resolver/aws_parameterstore_handler.go

@@ -44,6 +44,10 @@ func NewAwsParameterStoreHandler(a *kedav1alpha1.AwsParameterStore) *AwsParamete
 }
 
 func (apsh *AwsParameterStoreHandler) Read(ctx context.Context, logger logr.Logger, parameterName string, withDecryption *bool) (string, error) {
+	// WithDecryption defaults to true if not specified.
+	// For SecureString parameters, this must be true to retrieve the plaintext value.
+	// Set to false for SecureString parameters to retrieve the encrypted value.
+	// For String parameters, this setting has no effect.
 	decrypt := true
 	if withDecryption != nil {
 		decrypt = *withDecryption