-
-
Notifications
You must be signed in to change notification settings - Fork 57
fix(): Review blockout followups #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asturur
wants to merge
33
commits into
master
Choose a base branch
from
review-blockout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
cc4be64
minimal progress
asturur f080b63
Merge branch 'master' into review-blockout
asturur db14423
Merge branch 'master' into review-blockout
asturur e06aad7
1 hour of work 4 lines
asturur 860a4dd
more bits
asturur 1be3e1a
some progress
asturur 02079c9
board picture
asturur cb374da
Merge branch 'master' into review-blockout
asturur 46bf4dd
controls remap
asturur 65689b9
less errors
asturur 8ff6bba
correct toml
asturur 316d6e5
more pcb
asturur d2ce926
Merge branch 'master' into review-blockout
jotego dc1949e
Merge branch 'master' into review-blockout
asturur 3d3c9eb
Merge branch 'master' into review-blockout
asturur 08fda9a
is that all for point 1?
asturur 712144e
exact decoding
asturur 0072b7a
could this be - preserving byte writes - ?
asturur ac9f19a
leverage jtframe_edge
asturur 1d0dcfb
forgot this
asturur 642bb41
and this
asturur 6761f1e
Merge branch 'master' into review-blockout
asturur 916ae3b
missed the dots
asturur 49bc32b
send help
asturur 6f958ee
Merge branch 'master' into review-blockout
asturur 95ae968
added a colmix
asturur d4c587a
Merge branch 'review-blockout' of github.com:jotego/jtcores into revi…
asturur 819e378
enabled gfx_en + made register
asturur 2c0dd06
less comments
asturur 4beb5d3
forgot this file
asturur 23a9694
Merge branch 'master' into review-blockout
asturur 6c29497
Merge branch 'master' into review-blockout
asturur 0ebfee1
Merge branch 'master' into review-blockout
asturur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must be a multiple of 4 or it will break the Analogue Pocket firmware.