Skip to content

Argus core vibe coded by Fulvio - #1388

Draft
jotego wants to merge 26 commits into
masterfrom
argus
Draft

Argus core vibe coded by Fulvio#1388
jotego wants to merge 26 commits into
masterfrom
argus

Conversation

@jotego

@jotego jotego commented May 2, 2026

Copy link
Copy Markdown
Owner

@rp-jt review this one too. Look at my notes.

Copilot AI review requested due to automatic review settings May 2, 2026 16:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jotego jotego left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes needed

Comment thread cores/argus/cfg/macros.def Outdated
Comment thread cores/argus/cfg/mem.yaml
outputs:
- cen5
- cen5b
- freq: 1500000

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to engineering notation

Comment thread cores/argus/cfg/mem.yaml
- cen1p5
- cen1p5b

audio:

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check with PCB

Comment thread cores/argus/cfg/mem.yaml
end
end

jtframe_dual_ram #(

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to BRAM section in mem.yaml

Comment thread cores/argus/hdl/jtargus_palette.v Outdated
output reg [ 3:0] blend_alpha
);

reg [ 7:0] palram[0:12'hbff];

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use arrays, but instantiate jtframe_ram modules instead. This applies to base and spr_blend below too

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style of this file, with so many functions is very unlike the rest of the project.

wire ym_cs, ram_cs, latch_cs, int_n;
reg rst_n;

assign snd_addr = A;

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do memory decoding like in the other cores

.rom_ok ( snd_ok )
);

jt03 #(.YM2203_LUMPED(1)) u_ym2203(

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the LUMPED parameter unless there is evidence of the PCB being that way

Comment thread doc/custom.xml
@jotego

jotego commented May 2, 2026

Copy link
Copy Markdown
Owner Author

The core build should have no core-specific warnings either:

Warning (10036): Verilog HDL or VHDL warning at jtargus_game_sdram.v(66): object "sdram_offset_zero" assigned a value but never read File: /home/jtejada/jtcores-2/cores/argus/mister/jtargus_game_sdram.v Line: 66
Warning (10036): Verilog HDL or VHDL warning at jtargus_palette.v(19): object "palram" assigned a value but never read File: /home/jtejada/jtcores-2/cores/argus/hdl/jtargus_palette.v Line: 19
Warning (10036): Verilog HDL or VHDL warning at jtargus_palette.v(20): object "base" assigned a value but never read File: /home/jtejada/jtcores-2/cores/argus/hdl/jtargus_palette.v Line: 20
Warning (10036): Verilog HDL or VHDL warning at jtargus_palette.v(22): object "intensity" assigned a value but never read File: /home/jtejada/jtcores-2/cores/argus/hdl/jtargus_palette.v Line: 22
Warning (10027): Verilog HDL or VHDL warning at the jtargus_palette.v(29): index expression is not wide enough to address all of the elements in the array File: /home/jtejada/jtcores-2/cores/argus/hdl/jtargus_palette.v Line: 29
Warning (10776): Verilog HDL warning at jtargus_palette.v(93): variable grey in static task or function bg_effect may have unintended latch behavior File: /home/jtejada/jtcores-2/cores/argus/hdl/jtargus_palette.v Line: 93
Warning (10230): Verilog HDL assignment warning at jtargus_bg0.v(27): truncated value with size 32 to match size of target (20) File: /home/jtejada/jtcores-2/cores/argus/hdl/jtargus_bg0.v Line: 27
Warning (10036): Verilog HDL or VHDL warning at jtargus_colmix.v(23): object "bg0_opaque" assigned a value but never read File: /home/jtejada/jtcores-2/cores/argus/hdl/jtargus_colmix.v Line: 23

@jotego jotego assigned jotego and rp-jt and unassigned jotego May 2, 2026
@jotego jotego added the new core label May 2, 2026
@jotego

jotego commented May 2, 2026

Copy link
Copy Markdown
Owner Author

The bottom left chips could be 8x 1-bit SDRAM chips for a frame buffer. That would explain the 1-frame delay. Sadly, it is not possible to read the chip ID from the picture.

image

@rp-jt
rp-jt marked this pull request as draft June 3, 2026 07:32
@jotego
jotego force-pushed the master branch 2 times, most recently from 85f3d05 to 736ae04 Compare June 5, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants