Conversation
jotego
commented
May 2, 2026
| outputs: | ||
| - cen5 | ||
| - cen5b | ||
| - freq: 1500000 |
Owner
Author
There was a problem hiding this comment.
Change to engineering notation
| - cen1p5 | ||
| - cen1p5b | ||
|
|
||
| audio: |
| end | ||
| end | ||
|
|
||
| jtframe_dual_ram #( |
Owner
Author
There was a problem hiding this comment.
move to BRAM section in mem.yaml
| output reg [ 3:0] blend_alpha | ||
| ); | ||
|
|
||
| reg [ 7:0] palram[0:12'hbff]; |
Owner
Author
There was a problem hiding this comment.
Do not use arrays, but instantiate jtframe_ram modules instead. This applies to base and spr_blend below too
Owner
Author
There was a problem hiding this comment.
The style of this file, with so many functions is very unlike the rest of the project.
| wire ym_cs, ram_cs, latch_cs, int_n; | ||
| reg rst_n; | ||
|
|
||
| assign snd_addr = A; |
Owner
Author
There was a problem hiding this comment.
Do memory decoding like in the other cores
| .rom_ok ( snd_ok ) | ||
| ); | ||
|
|
||
| jt03 #(.YM2203_LUMPED(1)) u_ym2203( |
Owner
Author
There was a problem hiding this comment.
Remove the LUMPED parameter unless there is evidence of the PCB being that way
Owner
Author
|
The core build should have no core-specific warnings either: |
Owner
Author
rp-jt
marked this pull request as draft
June 3, 2026 07:32
jotego
force-pushed
the
master
branch
2 times, most recently
from
June 5, 2026 08:27
85f3d05 to
736ae04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@rp-jt review this one too. Look at my notes.