feat: Make the H.264 profile-level-id configurable. - #1296
Draft
th-aslam wants to merge 1 commit into
Draft
Conversation
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in H.264 fmtp in jicofo offers (42e01f) — deliberate interop floor or 2017 legacy? with @jallamsetty1: jicofo hardcodes
42e01f(Constrained Baseline) in every H.264 offer, a value dating to the 2017 Firefox workaround (#308). Some platform encoder factories don't advertise CBP while libwebrtc matches profiles exactly, so senders on those platforms silently fall back to software encoding — macOS VideoToolbox advertises only Baseline/Main/High (offering42001fon the same machine flips it to hardware encode,powerEfficient: true), and MediaFoundation on Windows reportedly behaves the same.This makes the value configurable:
jicofo.codec.video.h264.profile-level-id, default"42e01f"— the offer output is byte-identical to current behavior at default config (the existing param cramming is deliberately untouched to keep the change minimal).H264CodecConfigfollows the existingRtxCodecConfigWithLegacypattern, preserving the legacyENABLE_H264/H264_PTproperties.withNewConfigcovers an overridden value.A companion lib-jitsi-meet PR making the client-side H.264 profile filtering in
TPCUtils.tsconfigurable will follow, per the same thread.