feat: Make the p2p H.264 high profile stripping configurable. - #3072
Draft
th-aslam wants to merge 1 commit into
Draft
feat: Make the p2p H.264 high profile stripping configurable.#3072th-aslam wants to merge 1 commit into
th-aslam wants to merge 1 commit into
Conversation
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to jitsi/jicofo#1296, as discussed in the community thread with @jallamsetty1.
TPCUtils.mungeCodecOrderunconditionally strips the non-baseline H.264 payload types from the SDP on p2p connections (SDPUtil.stripCodec(mLine, codec, true)keeps onlyprofile-level-id=42*). For deployments that want to negotiate Main/High profile — e.g. hardware encoders that don't advertise the baseline profiles — this hardcoded strip undoes the codec configuration client-side.This makes it configurable:
videoQuality.h264.stripHighProfilein config.js, defaulttrue— behavior is unchanged unless a deployment opts out.STANDARD_CODEC_SETTINGSand the existing per-codec config overlay in theTPCUtilsconstructor, same pattern asscalabilityModeEnabled/useSimulcast.MockPeerConnectiongainscodecSettings/usesCodecSelectionAPI()somungeCodecOrderis now unit-testable; two new specs cover the default strip and the opt-out (full suite 537/537 green,tsc --noEmitand eslint clean).