Repository navigation
feat(server): phones register Expo push tokens with each server - #229
Merged
Merged
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Adds pushRegistrations.register/unregister RPCs (orchestration:read), a fork migration for push_registrations keyed by install id and bound to the calling session, and the pushNotifications capability. Rows of revoked or expired sessions are deleted before any delivery. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jayleaton
force-pushed
the
feat/push-registration-20261113
branch
from
November 14, 2026 03:41
98f9e6b to
0d4dfa9
Compare
jayleaton
marked this pull request as ready for review
November 14, 2026 04:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phones register their Expo push token directly with each server. No T3 Connect relay. First layer of three; #230 sends the pushes and #231 is the iOS app. Rebased onto main after the Ada rebrand (#235–#242).
pushRegistrations.register/unregisterRPCs, inCLIENT_GUARDED_RPC_SCOPESbehindorchestration:read. A push only reveals thread titles and states that a reader already sees.push_registrations. A row belongs to one install, and re-registering replaces it. A token that moves to a new install id (reinstall) drops its old row.capabilities.pushNotificationslets the phone skip older servers.Evidence
apps/server/src/push/PushRegistrations.test.tspasses. It covers upsert by install id, a token moving to a new install, and rows of revoked and expired sessions being deleted.RpcAuthorization.test.tsscope coverage includes the new RPCs.vp run check:changedon the rebased layer: all pass (format, lint, knip, typecheck, tests). The one localServerEnvironment.test.tsmismatch is the macOS/tmp→/private/tmpsymlink and passes withTMPDIR=/private/tmp.Merge Danger
Door: two-way. The new table is additive. A revert leaves an unused table.
Blast Radius: server. Two new RPCs and one capability flag. Existing RPCs are unchanged.
🤖 Generated with Claude Code