Skip to content

fix(mobile): dev icon matches its mark, update results sit beside their button - #237

Merged
jayleaton merged 2 commits into
mainfrom
fix/ada-ios-polish-20261113
Nov 13, 2026
Merged

jayleaton merged 2 commits into
mainfrom
fix/ada-ios-polish-20261113

Conversation

@jayleaton

Copy link
Copy Markdown
Owner

These are fixes from the final MacBook pass of #235 (gist 73b48c0d).

Summary

1. iOS widget mark: skipped. Upstream never drew it on this widget.

2. Dev home-screen icon now matches the dev in-app mark.

  • Production and preview keep the lavender Pip on navy.
  • Development builds now use the blueprint with a white Pip, like the desktop dev icon and the in-app BrandMark (assets/dev/blueprint-ios-1024.png).
  • scripts/export-android-icons.ts (vp run icons:export:android) renders both from assets/dev/app-icon.icon's background and annotation layers:
    • apps/mobile/assets/agents/dev-ios-icon-1024.png: full bleed, flattened with no alpha channel, because iOS applies its own mask and the App Store rejects transparency. The Icon Composer render already has its corners cut, so it can't be used.
    • apps/mobile/assets/agents/android-dev-icon-background.png: the adaptive background, under the existing white android-icon-monochrome.png foreground.
  • The other generated assets came out byte-identical.

Left to right: the current dev icon (same as prod), the in-app dev mark, the new iOS dev icon (shown masked), and the new Android dev icon (shown with a circle mask).

3. Environment → Check for updates.

  • Placement fixed. Every action on the environment screen shared one message slot, drawn above the Ada section, so a failed check looked like part of Routes. Each result now shows in its action's section:
    • the update check and server update results in the Ada section, under the version and next to Check for updates;
    • refresh and provider-update results in Providers.
  • Release track: already correct. No code change.
    • The track comes from the server's version.
    • Fork nightlies report versions like 0.1.9-nightly.20261113.485001, which read as nightly.
    • "keeps nightly and preview hosts on their channel…" in environment-maintenance.test.ts already shows a nightly host finding the newer nightly.
    • The MacBook pass was on a dev server reporting plain 0.1.9, which reads as stable. With no stable fork release, "No stable release was found." is the correct answer there.

Checks

  • vp run check:changed → pass: format, lint, knip, typecheck (2 packages), test, react compiler.
  • vp run icons:export:android reproduces every committed mobile asset.

MacBook captures needed

  1. Home-screen icon on a dev build: the blueprint with a white Pip, in light and dark. A production or preview build should still show navy with a lavender Pip.
  2. The dev build's loading screen BrandMark beside that icon, if it stays up long enough.
  3. Environment → Check for updates on a dev server (plain 0.1.9): "No stable release was found." in red inside the Ada section, under the version, not above it.
  4. The same on a nightly server (0.1.9-nightly.…): "Version … is available." or "You are up to date." in the Ada section.
  5. Providers → Refresh providers: "Provider status refreshed." now inside the Providers section.
  6. Android, if checked: the dev adaptive icon (blueprint inside the mask) and the themed monochrome icon.

Merge Danger

Door: two-way. Assets, one exporter step and one screen's message placement.

Blast Radius: mobile

  • Dev builds' native icon changes. The fingerprint changes for the development variant, so dev clients need a rebuild (vp run mobile:install).
  • Environment screen: action messages move into their sections. There's no behavior change.

Model and harness: Claude Opus 5.5 in Claude Code (T3 Code).

🤖 Generated with Claude Code

jayleaton and others added 2 commits November 13, 2026 20:43
The dev variant used the navy production icon while its in-app mark is the
blueprint. The Android exporter now renders a full-bleed blueprint iOS icon
and an adaptive blueprint background for the white monochrome Pip, without
alpha so iOS accepts the icon.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Environment actions shared one message slot above the Ada section, so a
failed check read as part of Routes. Each result now shows in the section of
the action that produced it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:L labels Nov 13, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.5 KiB 21.5 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 1 1 0 (0.0%) 8 ✅

Baseline: 22240d2 · PR result: d0dca11 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@jayleaton
jayleaton merged commit e2d428d into main Nov 13, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant