Skip to content

Fix nil error logging in probe registration #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afritzler merged 3 commits into from
May 26, 2026
+8 −1
Merged

Fix nil error logging in probe registration #874

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ecf4b0
Fix nil error logging in probe registration
stefanhipfel May 11, 2026
ef8ba72
fixes CodeRabbitAI issue
stefanhipfel May 15, 2026
8fd18f7
Fix unreachable code lint error in probe registration
stefanhipfel May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/probe/probe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import (
"bytes"
"context"
"encoding/json"
"fmt"
"io"
"net/http"
"time"

Expand Down Expand Up @@ -221,7 +223,12 @@ func (a *Agent) registerServer(ctx context.Context) error {
}()

if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusCreated {
Copy link
Copy Markdown
Contributor Author

@stefanhipfel stefanhipfel May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afritzler do we want to retry on all errors? 401 or 403 for example won't fix themselves

Copy link
Copy Markdown
Member

@afritzler afritzler May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO I would keep it simple for now. But you are are of course right.

a.log.Error(err, "Failed to register server", "url", a.RegistryURL)
body, readErr := io.ReadAll(io.LimitReader(resp.Body, 1024))
if readErr != nil {
a.log.Error(fmt.Errorf("HTTP %d: failed to read response body: %w", resp.StatusCode, readErr), "Failed to register server", "url", a.RegistryURL)
return false, nil
}
a.log.Error(fmt.Errorf("HTTP %d: %s", resp.StatusCode, string(body)), "Failed to register server", "url", a.RegistryURL)
return false, nil
}

Expand Down
Loading