Fix nil error logging in probe registration

[stefanhipfel]

Fixes #785

Summary by CodeRabbit

• Bug Fixes
  • Improved server registration error reporting: failures now include HTTP status codes and response body (or read error) to aid troubleshooting.
  • Replaced generic registration failure logs with detailed, formatted error messages for clearer diagnostics.

[coderabbitai]

Warning

Rate limit exceeded

@stefanhipfel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 46 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6dd6df48-7096-43ab-9cc8-d49d57320ed5

📥 Commits

Reviewing files that changed from the base of the PR and between f9f6ef8 and 8fd18f7.

📒 Files selected for processing (1)

• internal/probe/probe.go

📝 Walkthrough

Walkthrough

The probe agent's registerServer now captures HTTP response status and up to 1024 bytes of the response body on non-200/201 replies, and logs a formatted error containing that information while keeping retry/backoff behavior unchanged.

Changes

Server Registration Error Logging

Layer / File(s)	Summary
Import dependencies internal/probe/probe.go	Adds fmt and io imports to enable formatted error messages and limited response-body reading.
Error handling with response body internal/probe/probe.go	On non-200/201 HTTP responses, reads up to 1024 bytes from the response body and logs an error including the HTTP status code and either the read failure or the response text; returns (false, nil) to preserve retry logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• afritzler
• nagadeesh-nagaraja

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description only contains 'Fixes #785' and lacks details about the proposed changes. The template requires sections for 'Proposed Changes' with bullet points.	Expand the description to include specific proposed changes and implementation details that explain how the nil error logging issue is resolved.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Fix nil error logging in probe registration' accurately describes the main change—improving error logging in the probe registration function by handling nil errors.
Linked Issues check	✅ Passed	The PR changes address the core requirement from issue #785: reading response body and logging a concrete error with status code when HTTP registration returns non-OK responses.
Out of Scope Changes check	✅ Passed	All changes in internal/probe/probe.go directly address the nil error logging issue in registerServer from issue #785, with no unrelated modifications detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch worktree-issue_fixes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[stefanhipfel]

@afritzler do we want to retry on all errors? 401 or 403 for example won't fix themselves

[afritzler]

IMO I would keep it simple for now. But you are are of course right.

[afritzler]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@internal/probe/probe.go`:
- Around line 226-227: The call to io.ReadAll(io.LimitReader(resp.Body, 1024))
currently ignores its returned error which can hide read failures; modify the
code around the resp handling (where body, _ :=
io.ReadAll(io.LimitReader(resp.Body, 1024)) and the subsequent a.log.Error call
occur) to capture the read error (e.g., body, err := io.ReadAll(...)), and
include that error in the a.log.Error invocation or its message (alongside
resp.StatusCode, the body string and "url", a.RegistryURL) so read failures are
reported instead of discarded.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7b98ae21-b03a-4bd6-a547-be75c21e6bed

📥 Commits

Reviewing files that changed from the base of the PR and between bd30487 and 1ecf4b0.

📒 Files selected for processing (1)

• internal/probe/probe.go