Skip to content

Addressing review comments #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jatinwadhwa921 merged 1 commit into from
Jun 30, 2026
Merged

Addressing review comments #1171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions onnxruntime/test/providers/openvino/openvino_ep_workload_type_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,14 @@
}

// Allow NPU resources to be fully released between tests.
// Without this delay the NPU driver may fail to re-initialise
// Without this delay the NPU driver may fail to re-initialise.

Check notice on line 35 in onnxruntime/test/providers/openvino/openvino_ep_workload_type_test.cc

View workflow job for this annotation

GitHub Actions / misspell

[misspell] onnxruntime/test/providers/openvino/openvino_ep_workload_type_test.cc#L35 

"initialise" is a misspelling of "initialize"
Raw output 
./onnxruntime/test/providers/openvino/openvino_ep_workload_type_test.cc:35:54: "initialise" is a misspelling of "initialize"
// Skip the delay when the test was skipped (e.g. no NPU available), since no
// NPU resources were acquired and the sleep would only add build latency.
void TearDown() override {
std::this_thread::sleep_for(std::chrono::milliseconds(200));
if (IsSkipped()) {

@ankitm3k ankitm3k Jun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this stray function location can find it?

@jatinwadhwa921 jatinwadhwa921 Jun 29, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsSkipped() is inherited from GoogleTest's ::testing::Test base class

return;
}
std::this_thread::sleep_for(std::chrono::milliseconds(50));
}

static Ort::Session CreateSqueezeNetSession(
Expand Down
Loading