Addressing review comments#1171
Merged
Merged
Conversation
ankitm3k
reviewed
Jun 29, 2026
ankitm3k
left a comment
ankitm3k
left a comment
There was a problem hiding this comment.
basically the sleep duration its too high 200 msec we need to avoid the same when gtest_skip is called. rectify the same
jatinwadhwa921
force-pushed
the
jatin_fix_workload_type
branch
2 times, most recently
from
1ca072f to
0dff73a
Compare
ankitm3k
reviewed
Jun 29, 2026
| // NPU resources were acquired and the sleep would only add build latency. | ||
| void TearDown() override { | ||
| std::this_thread::sleep_for(std::chrono::milliseconds(200)); | ||
| if (IsSkipped()) { |
There was a problem hiding this comment.
where is this stray function location can find it?
Author
There was a problem hiding this comment.
IsSkipped() is inherited from GoogleTest's ::testing::Test base class
jatinwadhwa921
force-pushed
the
jatin_fix_workload_type
branch
from
0dff73a to
4e611af
Compare
jatinwadhwa921
added a commit
that referenced
this pull request
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.