Skip to content

Add integration tests#388

Closed
jlaehne wants to merge 6 commits into
hyperspy:mainfrom
jlaehne:extension-tests
Closed

Add integration tests#388
jlaehne wants to merge 6 commits into
hyperspy:mainfrom
jlaehne:extension-tests

Conversation

@jlaehne

@jlaehne jlaehne commented Apr 6, 2025

Copy link
Copy Markdown
Member

Add test run with hyperspy and its extensions installed. Run rosettasciio, hyperspy and extension tests.

Progress of the PR

  • Change implemented (can be split into several points),
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • add tests,
  • ready for review.

@codecov

codecov Bot commented Apr 6, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.00%. Comparing base (f3d59ca) to head (b7b47df).
⚠️ Report is 77 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   88.02%   88.00%   -0.02%     
==========================================
  Files          91       91              
  Lines       11538    11538              
  Branches     2131     2131              
==========================================
- Hits        10156    10154       -2     
- Misses        875      876       +1     
- Partials      507      508       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericpre

ericpre commented Apr 6, 2025

Copy link
Copy Markdown
Member

Just ran the workflow in hyperspy: https://github.com/hyperspy/hyperspy/actions/runs/14291193279/job/40052635962 and there are a few test suite that fails and from a quick look, it seems to be related to an issues in the test suite of the extension.

For now, a pragmatic approach could be to skip these test suite, until this is fixed - running rosettasciio test suite with the extension installed is already an improvement and useful.

At some point, it would be good to see if reusable workflow can be used, otherwise, this can be end up being a maintenance burden or not working most of the time!

@jlaehne jlaehne added run-integration-tests Run integration tests workflow and removed run-integration-tests Run integration tests workflow labels Apr 6, 2025
@jlaehne

jlaehne commented Apr 6, 2025

Copy link
Copy Markdown
Member Author

Indeed, it is probably enough to run the Rosetta tests with extensions installed here and leave further integration tests to HyperSpy.

@ericpre ericpre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be documented somewhere, pull request template or contributor guide?

Comment thread .github/workflows/tests_hs-extension.yml Outdated
@ericpre ericpre added run-integration-tests Run integration tests workflow and removed run-integration-tests Run integration tests workflow labels Apr 9, 2025
@ericpre ericpre added run-integration-tests Run integration tests workflow and removed run-integration-tests Run integration tests workflow labels Jul 18, 2025
@ericpre ericpre mentioned this pull request Jul 20, 2025
4 tasks
@jlaehne

jlaehne commented Jul 24, 2025

Copy link
Copy Markdown
Member Author

Superseded by #426

@jlaehne jlaehne closed this Jul 24, 2025
@ericpre ericpre removed the run-integration-tests Run integration tests workflow label Jul 26, 2025
@jlaehne jlaehne deleted the extension-tests branch July 27, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants