Set correct signal type of Hamamatsu tiff images, if lumispy is installed#386
Conversation
|
There was an error handling pipeline event 4c4b94c0-44df-427b-a073-de66fb4b7e03. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
=======================================
Coverage 87.90% 87.90%
=======================================
Files 86 86
Lines 11269 11271 +2
Branches 2088 2088
=======================================
+ Hits 9906 9908 +2
Misses 864 864
Partials 499 499 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| signal["signal_type"] = "" | ||
| else: | ||
| signal["signal_type"] = "LumiTransientSpectrum" # pragma: no cover | ||
| signal["signal_type"] = "LumiTransientSpectrum" |
There was a problem hiding this comment.
Would it be worth adding a build on GitHub CI that install extensions (lumispy, pyxem, etc.) to test this kind of thing?
There was a problem hiding this comment.
Possibly. That is what the integration tests on the hyperspy-extensions-list repro are doing - but then it is not noticed as directly if something goes wrong. I can also add back the pragma: no cover and we leave it to the integration tests to run this part?
There was a problem hiding this comment.
That is what the integration tests on the
hyperspy-extensions-listrepro are doing - but then it is not noticed as directly if something goes wrong.
Indeed, but this can be tedious when fixing it or figure out what needs to be fixed. We could use the same approach as in hyperspy with a separate workflow that runs on demand (https://github.com/hyperspy/hyperspy/blob/RELEASE_next_minor/.github/workflows/tests_extension.yml) but we trend to forget about it and also it doesn't help with the coverage.
There was a problem hiding this comment.
Regarding the coverage, should we add back # pragma: no cover, to silent coverage warning and add a comment that this is tested in the integration test workflow but the coverage is not reported?
5f21245 to
31f2b3b
Compare
Set
signal_typeof Hamamatsu streak images loaded fromtiffformat toTransientSpectrum(LumiTransientSpectrumclass), if lumispy is installed.Add tests to tiff and hamamatsu readers that run when lumispy is available.
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),docs/readthedocs.org:rosettasciiobuild of this PR (link in github checks)