Skip to content

Fixes: Circle CI and Docker build failing due to unupdated version of node #6397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramyaragupathy merged 2 commits into from
May 1, 2024
Merged

Fixes: Circle CI and Docker build failing due to unupdated version of node #6397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf92789
infra: Updates to dockerfile & circleci images for node v18 upgrade
mahesh-naxa May 1, 2024
4dd471e
docs: updated version docs to v18
mahesh-naxa May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
frontend-code-test:
resource_class: large
docker:
- image: cimg/node:16.20
- image: cimg/node:18.19.1
working_directory: /home/circleci/tasking-manager
steps:
- checkout
Expand Down Expand Up @@ -184,7 +184,7 @@ jobs:
working_directory: /home/circleci/tasking-manager
resource_class: medium
docker:
- image: cimg/python:3.10.7-node
- image: cimg/node:18.19.1
steps:
- checkout
- aws-cli/setup:
Expand Down Expand Up @@ -237,7 +237,7 @@ jobs:
working_directory: /home/circleci/tasking-manager
resource_class: large
docker:
- image: cimg/python:3.10.7-node
- image: cimg/node:18.19.1
parameters:
stack_name:
description: "the name of the stack for cfn-config"
Expand Down
2 changes: 1 addition & 1 deletion docs/developers/development-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ The client is the front-end user interface of the Tasking Manager. It is based o
#### Dependencies

The following dependencies must be available _globally_ on your system:
* Download and install [NodeJS LTS v12+](https://nodejs.org/en/) and [yarn](https://classic.yarnpkg.com/en/docs/install)
* Download and install [Node 18.xx](https://nodejs.org/en/download) and [yarn](https://classic.yarnpkg.com/en/docs/install)
* Go into the `frontend` directory and execute `yarn`.

#### Available Scripts
Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,6 @@
]
},
"volta": {
"node": "16.20.0"
"node": "18.19.1"
}
}
2 changes: 1 addition & 1 deletion scripts/docker/Dockerfile.frontend
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18 as build
FROM node:18.19.1 as build

WORKDIR /usr/src/app/frontend
COPY frontend .
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker/Dockerfile.frontend_development
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18
FROM node:18.19.1

WORKDIR /usr/src/app

Expand Down